ntdll: Only add a module dependency if import_dll() returned a modref.

In particular, if import_dll() skips an unused import, it will return TRUE, but set *pwm to NULL. This fixes a regression in 3DMark03 version 3.4.0, introduced by commit 0dd37b02. Signed-off-by: Henri Verbeet <hverbeet@codeweavers.com> Signed-off-by: Alexandre Julliard <julliard@winehq.org>

ntdll: Only add a module dependency if import_dll() returned a modref.
deff68bb · Henri Verbeet · Alexandre Julliard · 6944dc51 · deff68bb
Commit deff68bb authored Nov 18, 2021 by Henri Verbeet Committed by Alexandre Julliard Nov 18, 2021
Hide whitespace changes
Inline Side-by-side

Showing with 1 addition and 1 deletion

loader.c dlls/ntdll/loader.c +1 -1

No files found.
--- a/dlls/ntdll/loader.c
+++ b/dlls/ntdll/loader.c
@@ -1282,7 +1282,7 @@ static NTSTATUS fixup_imports( WINE_MODREF *wm, LPCWSTR load_path )
            imp = NULL;
            status = STATUS_DLL_NOT_FOUND;
        }
-        else if (!is_import_dll_system( &wm->ldr, &imports[i] ))
+        else if (imp && !is_import_dll_system( &wm->ldr, &imports[i] ))
        {
            add_module_dependency_after( wm->ldr.DdagNode, imp->ldr.DdagNode, dep_after );
        }