dbghelp: Check that we don't add same line number twice.

This happens (at least) in dwarf debug info where there could be two entries with same source file and line number, but different column numbers (and we don't store columns). Signed-off-by: Eric Pouech <eric.pouech@gmail.com> Signed-off-by: Alexandre Julliard <julliard@winehq.org>

dbghelp: Check that we don't add same line number twice.
e105e9d3 · Eric Pouech · Alexandre Julliard · 27b7a96d · e105e9d3
Commit e105e9d3 authored Nov 08, 2021 by Eric Pouech Committed by Alexandre Julliard Nov 08, 2021
Hide whitespace changes
Inline Side-by-side

Showing with 5 additions and 0 deletions

symbol.c dlls/dbghelp/symbol.c +5 -0

No files found.
--- a/dlls/dbghelp/symbol.c
+++ b/dlls/dbghelp/symbol.c
@@ -418,6 +418,11 @@ void symt_add_func_line(struct module* module, struct symt_function* func,
    }
    vlen = vector_length(&func->vlines);
    prev = vlen ? vector_at(&func->vlines, vlen - 1) : NULL;
+    if (last_matches && prev && addr == prev->u.address)
+    {
+        WARN("Duplicate addition of line number in %s\n", func->hash_elt.name);
+        return;
+    }
    if (!last_matches)
    {
        /* we shouldn't have line changes on first line of function */