Commit e4451427 authored by Nikolay Sivov's avatar Nikolay Sivov Committed by Alexandre Julliard

oleaut32: Fix uninitialized variable access in VarXor() for earlier failure paths (Coverity).

parent 2fe70331
...@@ -4635,6 +4635,7 @@ HRESULT WINAPI VarXor(LPVARIANT pVarLeft, LPVARIANT pVarRight, LPVARIANT pVarOut ...@@ -4635,6 +4635,7 @@ HRESULT WINAPI VarXor(LPVARIANT pVarLeft, LPVARIANT pVarRight, LPVARIANT pVarOut
return S_OK; return S_OK;
} }
V_VT(&varLeft) = V_VT(&varRight) = VT_EMPTY;
VariantInit(&tempLeft); VariantInit(&tempLeft);
VariantInit(&tempRight); VariantInit(&tempRight);
...@@ -4653,8 +4654,6 @@ HRESULT WINAPI VarXor(LPVARIANT pVarLeft, LPVARIANT pVarRight, LPVARIANT pVarOut ...@@ -4653,8 +4654,6 @@ HRESULT WINAPI VarXor(LPVARIANT pVarLeft, LPVARIANT pVarRight, LPVARIANT pVarOut
} }
/* Copy our inputs so we don't disturb anything */ /* Copy our inputs so we don't disturb anything */
V_VT(&varLeft) = V_VT(&varRight) = VT_EMPTY;
hRet = VariantCopy(&varLeft, pVarLeft); hRet = VariantCopy(&varLeft, pVarLeft);
if (FAILED(hRet)) if (FAILED(hRet))
goto VarXor_Exit; goto VarXor_Exit;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment