oleaut32: Fix uninitialized variable access in VarXor() for earlier failure paths (Coverity).

Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com> Signed-off-by: Alexandre Julliard <julliard@winehq.org>

oleaut32: Fix uninitialized variable access in VarXor() for earlier failure paths (Coverity).
e4451427 · Nikolay Sivov · Alexandre Julliard · 2fe70331 · e4451427
Commit e4451427 authored Sep 14, 2021 by Nikolay Sivov Committed by Alexandre Julliard Sep 14, 2021
Show whitespace changes
Inline Side-by-side

Showing with 1 addition and 2 deletions

variant.c dlls/oleaut32/variant.c +1 -2

No files found.
--- a/dlls/oleaut32/variant.c
+++ b/dlls/oleaut32/variant.c
@@ -4635,6 +4635,7 @@ HRESULT WINAPI VarXor(LPVARIANT pVarLeft, LPVARIANT pVarRight, LPVARIANT pVarOut
        return S_OK;
    }

+    V_VT(&varLeft) = V_VT(&varRight) = VT_EMPTY;
    VariantInit(&tempLeft);
    VariantInit(&tempRight);

@@ -4653,8 +4654,6 @@ HRESULT WINAPI VarXor(LPVARIANT pVarLeft, LPVARIANT pVarRight, LPVARIANT pVarOut
    }

    /* Copy our inputs so we don't disturb anything */
-    V_VT(&varLeft) = V_VT(&varRight) = VT_EMPTY;
-
    hRet = VariantCopy(&varLeft, pVarLeft);
    if (FAILED(hRet))
        goto VarXor_Exit;