Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
W
wine-cw
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
wine
wine-cw
Commits
e4ec89f2
Commit
e4ec89f2
authored
Oct 14, 2015
by
Huw Davies
Committed by
Alexandre Julliard
Oct 15, 2015
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
ole32: Return OLE_E_NOTRUNNING on a cache-miss when the object isn't running.
Signed-off-by:
Huw Davies
<
huw@codeweavers.com
>
Signed-off-by:
Alexandre Julliard
<
julliard@winehq.org
>
parent
4fcc5fec
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
20 additions
and
4 deletions
+20
-4
defaulthandler.c
dlls/ole32/defaulthandler.c
+20
-2
ole2.c
dlls/ole32/tests/ole2.c
+0
-2
No files found.
dlls/ole32/defaulthandler.c
View file @
e4ec89f2
...
...
@@ -1021,8 +1021,17 @@ static HRESULT WINAPI DefaultHandler_GetData(
IDataObject_Release
(
cacheDataObject
);
if
(
FAILED
(
hres
)
&&
object_is_running
(
This
))
if
(
hres
==
S_OK
)
return
hres
;
if
(
object_is_running
(
This
))
{
hres
=
IDataObject_GetData
(
This
->
pDataDelegate
,
pformatetcIn
,
pmedium
);
if
(
hres
==
S_OK
)
return
hres
;
}
/* Query running state again, as the object may have closed during _GetData call */
if
(
!
object_is_running
(
This
))
hres
=
OLE_E_NOTRUNNING
;
return
hres
;
}
...
...
@@ -1067,8 +1076,17 @@ static HRESULT WINAPI DefaultHandler_QueryGetData(
IDataObject_Release
(
cacheDataObject
);
if
(
FAILED
(
hres
)
&&
object_is_running
(
This
))
if
(
hres
==
S_OK
)
return
hres
;
if
(
object_is_running
(
This
))
{
hres
=
IDataObject_QueryGetData
(
This
->
pDataDelegate
,
pformatetc
);
if
(
hres
==
S_OK
)
return
hres
;
}
/* Query running state again, as the object may have closed during _QueryGetData call */
if
(
!
object_is_running
(
This
))
hres
=
OLE_E_NOTRUNNING
;
return
hres
;
}
...
...
dlls/ole32/tests/ole2.c
View file @
e4ec89f2
...
...
@@ -1933,7 +1933,6 @@ static void test_default_handler(void)
fmtetc
.
lindex
=
-
1
;
fmtetc
.
tymed
=
TYMED_ENHMF
;
hr
=
IDataObject_QueryGetData
(
pDataObject
,
&
fmtetc
);
todo_wine
ok
(
hr
==
OLE_E_NOTRUNNING
,
"IDataObject_QueryGetData should have returned OLE_E_NOTRUNNING instead of 0x%08x
\n
"
,
hr
);
fmtetc
.
cfFormat
=
CF_TEXT
;
...
...
@@ -1942,7 +1941,6 @@ static void test_default_handler(void)
fmtetc
.
lindex
=
-
1
;
fmtetc
.
tymed
=
TYMED_NULL
;
hr
=
IDataObject_QueryGetData
(
pDataObject
,
&
fmtetc
);
todo_wine
ok
(
hr
==
OLE_E_NOTRUNNING
,
"IDataObject_QueryGetData should have returned OLE_E_NOTRUNNING instead of 0x%08x
\n
"
,
hr
);
hr
=
IOleObject_QueryInterface
(
pObject
,
&
IID_IRunnableObject
,
(
void
**
)
&
pRunnableObject
);
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment