msi: Remove read-only bit when copying the package file.

CopyFileW also copies the file attributes, and the copy will be opened with write access later on. Signed-off-by: Jérôme Gardou <jerome.gardou@reactos.org> Signed-off-by: Hans Leidekker <hans@codeweavers.com> Signed-off-by: Alexandre Julliard <julliard@winehq.org>

msi: Remove read-only bit when copying the package file.
e8309758 · JÃ©rÃ´me Gardou · Alexandre Julliard · d6fed9c3 · e8309758
Commit e8309758 authored Feb 12, 2021 by JÃ©rÃ´me Gardou Committed by Alexandre Julliard Feb 16, 2021
Hide whitespace changes
Inline Side-by-side

Showing with 7 additions and 0 deletions

package.c dlls/msi/package.c +7 -0

No files found.
--- a/dlls/msi/package.c
+++ b/dlls/msi/package.c
@@ -1371,6 +1371,8 @@ UINT MSI_OpenPackageW(LPCWSTR szPackage, DWORD dwOptions, MSIPACKAGE **pPackage)
        r = get_local_package( db, localfile );
        if (r != ERROR_SUCCESS || GetFileAttributesW( localfile ) == INVALID_FILE_ATTRIBUTES)
        {
+            DWORD localfile_attr;
+
            r = msi_create_empty_local_file( localfile, L".msi" );
            if (r != ERROR_SUCCESS)
            {
@@ -1387,6 +1389,11 @@ UINT MSI_OpenPackageW(LPCWSTR szPackage, DWORD dwOptions, MSIPACKAGE **pPackage)
                return r;
            }
            delete_on_close = TRUE;
+
+            /* Remove read-only bit, we are opening it with write access in MSI_OpenDatabaseW below. */
+            localfile_attr = GetFileAttributesW( localfile );
+            if (localfile_attr & FILE_ATTRIBUTE_READONLY)
+                SetFileAttributesW( localfile, localfile_attr & ~FILE_ATTRIBUTE_READONLY);
        }
        else if (dwOptions & WINE_OPENPACKAGEFLAGS_RECACHE)
        {