Commit e94df274 authored by Paul Vriens's avatar Paul Vriens Committed by Alexandre Julliard

ntdll: Fixed conditional expression (Coverity).

parent e41c0acc
...@@ -517,7 +517,7 @@ NTSTATUS WINAPI RtlpNtQueryValueKey( HANDLE handle, ULONG *result_type, PBYTE de ...@@ -517,7 +517,7 @@ NTSTATUS WINAPI RtlpNtQueryValueKey( HANDLE handle, ULONG *result_type, PBYTE de
UNICODE_STRING name; UNICODE_STRING name;
NTSTATUS ret; NTSTATUS ret;
DWORD dwResultLen; DWORD dwResultLen;
DWORD dwLen = sizeof (KEY_VALUE_PARTIAL_INFORMATION) + result_len ? *result_len : 0; DWORD dwLen = sizeof (KEY_VALUE_PARTIAL_INFORMATION) + (result_len ? *result_len : 0);
info = (KEY_VALUE_PARTIAL_INFORMATION*)RtlAllocateHeap( GetProcessHeap(), 0, dwLen ); info = (KEY_VALUE_PARTIAL_INFORMATION*)RtlAllocateHeap( GetProcessHeap(), 0, dwLen );
if (!info) if (!info)
......
...@@ -103,6 +103,7 @@ static NTSTATUS (WINAPI * pRtlUnicodeStringToAnsiString)(PSTRING, PUNICODE_STRIN ...@@ -103,6 +103,7 @@ static NTSTATUS (WINAPI * pRtlUnicodeStringToAnsiString)(PSTRING, PUNICODE_STRIN
static NTSTATUS (WINAPI * pRtlFreeHeap)(PVOID, ULONG, PVOID); static NTSTATUS (WINAPI * pRtlFreeHeap)(PVOID, ULONG, PVOID);
static NTSTATUS (WINAPI * pRtlAllocateHeap)(PVOID,ULONG,ULONG); static NTSTATUS (WINAPI * pRtlAllocateHeap)(PVOID,ULONG,ULONG);
static NTSTATUS (WINAPI * pRtlZeroMemory)(PVOID, ULONG); static NTSTATUS (WINAPI * pRtlZeroMemory)(PVOID, ULONG);
static NTSTATUS (WINAPI * pRtlpNtQueryValueKey)(HANDLE,ULONG*,PBYTE,DWORD*);
static HMODULE hntdll = 0; static HMODULE hntdll = 0;
static int CurrentTest = 0; static int CurrentTest = 0;
...@@ -146,6 +147,7 @@ static BOOL InitFunctionPtrs(void) ...@@ -146,6 +147,7 @@ static BOOL InitFunctionPtrs(void)
NTDLL_GET_PROC(RtlFreeHeap) NTDLL_GET_PROC(RtlFreeHeap)
NTDLL_GET_PROC(RtlAllocateHeap) NTDLL_GET_PROC(RtlAllocateHeap)
NTDLL_GET_PROC(RtlZeroMemory) NTDLL_GET_PROC(RtlZeroMemory)
NTDLL_GET_PROC(RtlpNtQueryValueKey)
} }
return TRUE; return TRUE;
} }
...@@ -445,6 +447,14 @@ static void test_NtDeleteKey(void) ...@@ -445,6 +447,14 @@ static void test_NtDeleteKey(void)
ok(status == STATUS_SUCCESS, "NtDeleteKey Failed: 0x%08lx\n", status); ok(status == STATUS_SUCCESS, "NtDeleteKey Failed: 0x%08lx\n", status);
} }
static void test_RtlpNtQueryValueKey(void)
{
NTSTATUS status;
status = pRtlpNtQueryValueKey(NULL, NULL, NULL, NULL);
ok(status == STATUS_INVALID_HANDLE, "Expected STATUS_INVALID_HANDLE, got: 0x%08lx\n", status);
}
START_TEST(reg) START_TEST(reg)
{ {
static const WCHAR winetest[] = {'\\','W','i','n','e','T','e','s','t','\\',0}; static const WCHAR winetest[] = {'\\','W','i','n','e','T','e','s','t','\\',0};
...@@ -463,6 +473,7 @@ START_TEST(reg) ...@@ -463,6 +473,7 @@ START_TEST(reg)
test_RtlCheckRegistryKey(); test_RtlCheckRegistryKey();
test_RtlOpenCurrentUser(); test_RtlOpenCurrentUser();
test_RtlQueryRegistryValues(); test_RtlQueryRegistryValues();
test_RtlpNtQueryValueKey();
test_NtFlushKey(); test_NtFlushKey();
test_NtDeleteKey(); test_NtDeleteKey();
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment