setupapi: Correctly handle errors in fake_dlls_callback (Coverity).

edd9066d · Frédéric Delanoy · Alexandre Julliard · 882d126d · edd9066d
Commit edd9066d authored Jan 19, 2012 by Frédéric Delanoy Committed by Alexandre Julliard Jan 19, 2012
Hide whitespace changes
Inline Side-by-side

Showing with 1 addition and 3 deletions

install.c dlls/setupapi/install.c +1 -3

No files found.
--- a/dlls/setupapi/install.c
+++ b/dlls/setupapi/install.c
@@ -701,7 +701,6 @@ static BOOL register_dlls_callback( HINF hinf, PCWSTR field, void *arg )
 static BOOL fake_dlls_callback( HINF hinf, PCWSTR field, void *arg )
 {
    INFCONTEXT context;
-    BOOL ret = TRUE;
    BOOL ok = SetupFindFirstLineW( hinf, field, NULL, &context );

    for (; ok; ok = SetupFindNextLine( &context, &context ))
@@ -730,9 +729,8 @@ static BOOL fake_dlls_callback( HINF hinf, PCWSTR field, void *arg )

    done:
        HeapFree( GetProcessHeap(), 0, path );
-        if (!ret) break;
    }
-    return ret;
+    return TRUE;
 }

 /***********************************************************************