wined3d: Explicitly bind 0 for a NULL SRV.

Currently we invalidate STATE_SAMPLER whenever an SRV is bound, and hence rely on sampler() to do this for us, which is a bit obscure and won't work with the next patch.

wined3d: Explicitly bind 0 for a NULL SRV.
ef290846 · Zebediah Figura · Alexandre Julliard · d95a04b4 · ef290846
Commit ef290846 authored Nov 20, 2023 by Zebediah Figura Committed by Alexandre Julliard Dec 01, 2023
Show whitespace changes
Inline Side-by-side

Showing with 11 additions and 5 deletions

context_gl.c dlls/wined3d/context_gl.c +11 -5

No files found.
--- a/dlls/wined3d/context_gl.c
+++ b/dlls/wined3d/context_gl.c
@@ -3966,6 +3966,7 @@ void context_state_drawbuf(struct wined3d_context *context, const struct wined3d
 static void wined3d_context_gl_bind_shader_resources(struct wined3d_context_gl *context_gl,
        const struct wined3d_state *state, enum wined3d_shader_type shader_type)
 {
+    const struct wined3d_gl_info *gl_info = context_gl->gl_info;
    unsigned int bind_idx, shader_sampler_count, base, count, i;
    const struct wined3d_device *device = context_gl->c.device;
    struct wined3d_shader_sampler_map_entry *entry;
@@ -3993,12 +3994,8 @@ static void wined3d_context_gl_bind_shader_resources(struct wined3d_context_gl *
        if (tex_unit_map)
            bind_idx = tex_unit_map[bind_idx];

-        if (!(view = state->shader_resource_view[shader_type][entry->resource_idx]))
+        if ((view = state->shader_resource_view[shader_type][entry->resource_idx]))
        {
-            WARN("No resource view bound at index %u, %u.\n", shader_type, entry->resource_idx);
-            continue;
-        }
-
            if (entry->sampler_idx == WINED3D_SAMPLER_DEFAULT)
                sampler = device->default_sampler;
            else if (!(sampler = state->sampler[shader_type][entry->sampler_idx]))
@@ -4006,6 +4003,15 @@ static void wined3d_context_gl_bind_shader_resources(struct wined3d_context_gl *
            wined3d_shader_resource_view_gl_bind(wined3d_shader_resource_view_gl(view),
                    bind_idx, wined3d_sampler_gl(sampler), context_gl);
        }
+        else
+        {
+            WARN("No resource view bound at index %u, %u.\n", shader_type, entry->resource_idx);
+            wined3d_context_gl_active_texture(context_gl, gl_info, bind_idx);
+            wined3d_context_gl_bind_texture(context_gl, GL_NONE, 0);
+            if (gl_info->supported[ARB_SAMPLER_OBJECTS])
+                GL_EXTCALL(glBindSampler(bind_idx, 0));
+        }
+    }
 }

 static void wined3d_context_gl_bind_unordered_access_views(struct wined3d_context_gl *context_gl,