Commit f917cd0e authored by Marcus Meissner's avatar Marcus Meissner Committed by Alexandre Julliard

user.exe: Avoid truncating strcmp result (Coverity).

parent 0ef705fb
......@@ -2557,7 +2557,14 @@ INT16 WINAPIV wsprintf16( LPSTR buffer, LPCSTR spec, VA_LIST16 valist )
*/
INT16 WINAPI lstrcmp16( LPCSTR str1, LPCSTR str2 )
{
return strcmp( str1, str2 );
int ret;
/* Looks too complicated, but in optimized strcpy we might get
* a 32bit wide difference and would truncate it to 16 bit, so
* erroneously returning equality. */
ret = strcmp( str1, str2 );
if (ret < 0) return -1;
if (ret > 0) return 1;
return 0;
}
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment