• Kevin Puetz's avatar
    winecrt0: Remove free_delay_imports. · b5d3759f
    Kevin Puetz authored
    MSVC's delayimp.lib does not actually free delayload dependencies.
    winecrt0's attempt to do so from ELF __attribute__((destructor))
    is unnecessary and potentially harmful:
    
    - When triggered naturally via LdrUnloadDll, this leads to recursive calls
      to FreeLibrary, violating free_lib_count and missing DLL_PROCESS_DETACH
    - when triggered by glibc's _dl_fini (at process exit), it leads to
      use-after-free of the TEB (GetCurrentThreadID after the main thread is no longer Win32)
      via  FreeLibrary -> LdrLdrUnloadDll -> RtlEnterCriticalSection( &loader_section )
    - double-free of the library itself, since the DLL_PROCESS_DETACH has
      already been handled by LdrShutdownProcess
    - Race against wineserver sending a SIGKILL from process_killed,
      since all Win32 threads of the process have exited
    
    Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53032
    b5d3759f
Name
Last commit
Last update
..
Makefile.in Loading commit data...
crt_dllmain.c Loading commit data...
crt_fltused.c Loading commit data...
debug.c Loading commit data...
delay_load.c Loading commit data...
dll_canunload.c Loading commit data...
dll_main.c Loading commit data...
dll_register.c Loading commit data...
exception.c Loading commit data...
exe16_entry.c Loading commit data...
exe_entry.c Loading commit data...
exe_main.c Loading commit data...
exe_wentry.c Loading commit data...
exe_wmain.c Loading commit data...
register.c Loading commit data...
setjmp.c Loading commit data...
stub.c Loading commit data...
unix_lib.c Loading commit data...