windowscodecs: Avoid implicit cast changing value.

This appear to be introduced with commit 12f73ed9. When This->stride is negative (bottom up image) it converts the multiplication to an UINT. Thus causing the pointer to be incorrect when y > 0.

windowscodecs: Avoid implicit cast changing value.
013f54af · Alistair Leslie-Hughes · Alexandre Julliard · 4ae893e2 · 013f54af · 013f54af
Commit 013f54af authored May 02, 2024 by Alistair Leslie-Hughes Committed by Alexandre Julliard May 02, 2024
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 2 deletions

bmpdecode.c dlls/windowscodecs/bmpdecode.c +1 -1

wincodecs_common.h dlls/windowscodecs/wincodecs_common.h +1 -1

No files found.
--- a/dlls/windowscodecs/bmpdecode.c
+++ b/dlls/windowscodecs/bmpdecode.c
@@ -432,7 +432,7 @@ static HRESULT BmpFrameDecode_ReadABGRasBGR(BmpDecoder* This)
    {
        for (y = 0; y < height; y++)
        {
-            pixel = This->imagedatastart + This->stride * y;
+            pixel = This->imagedatastart + This->stride * (INT)y;

            for (x = 0; x < width; x++)
            {

--- a/dlls/windowscodecs/wincodecs_common.h
+++ b/dlls/windowscodecs/wincodecs_common.h
@@ -201,7 +201,7 @@ void reverse_bgr8(UINT bytesperpixel, LPBYTE bits, UINT width, UINT height, INT 

    for (y=0; y<height; y++)
    {
-        pixel = bits + stride * y;
+        pixel = bits + stride * (INT)y;

        for (x=0; x<width; x++)
        {