Prevent segfault in setsockopt when optname is SO_LINGER and optval is

null.

Prevent segfault in setsockopt when optname is SO_LINGER and optval is
0875d6e9 · Stephen Langasek · Alexandre Julliard · 882c1bef · 0875d6e9
Commit 0875d6e9 authored Dec 14, 1998 by Stephen Langasek Committed by Alexandre Julliard Dec 14, 1998
Hide whitespace changes
Inline Side-by-side

Showing with 3 additions and 1 deletion

winsock.c misc/winsock.c +3 -1

No files found.
--- a/misc/winsock.c
+++ b/misc/winsock.c
@@ -1477,10 +1477,12 @@ INT32 WINAPI WINSOCK_setsockopt32(SOCKET16 s, INT32 level, INT32 optname,
 	struct	linger linger;

 	convert_sockopt(&level, &optname);
-	if (optname == SO_LINGER) {
+	if (optname == SO_LINGER && optval) {
 		/* yes, uses unsigned short in both win16/win32 */
 		linger.l_onoff	= ((UINT16*)optval)[0];
 		linger.l_linger	= ((UINT16*)optval)[1];
+		/* FIXME: what is documented behavior if SO_LINGER optval
+		   is null?? */
 		optval = (char*)&linger;
 		optlen = sizeof(struct linger);
 	}