server: Return STATUS_KEY_DELETED when trying to retrieve the full name of a deleted key.

This fixes a server crash that can be triggered by deleting a key and then trying to retrieve its name. In that case key->parent is NULL. Signed-off-by: Zebediah Figura <z.figura12@gmail.com> Signed-off-by: Alexandre Julliard <julliard@winehq.org>

server: Return STATUS_KEY_DELETED when trying to retrieve the full name of a deleted key.
089b2528 · Zebediah Figura · Alexandre Julliard · e759da26 · 089b2528
Commit 089b2528 authored Jun 30, 2021 by Zebediah Figura Committed by Alexandre Julliard Jul 01, 2021
Hide whitespace changes
Inline Side-by-side

Showing with 6 additions and 0 deletions

registry.c server/registry.c +6 -0

No files found.
--- a/server/registry.c
+++ b/server/registry.c
@@ -413,6 +413,12 @@ static WCHAR *key_get_full_name( struct object *obj, data_size_t *ret_len )
    data_size_t len = sizeof(root_name) - sizeof(WCHAR);
    char *ret;

+    if (key->flags & KEY_DELETED)
+    {
+        set_error( STATUS_KEY_DELETED );
+        return NULL;
+    }
+
    for (key = (struct key *)obj; key != root_key; key = key->parent) len += key->namelen + sizeof(WCHAR);
    if (!(ret = malloc( len ))) return NULL;