Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
W
wine-winehq
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
wine
wine-winehq
Commits
098b3c72
Commit
098b3c72
authored
Nov 16, 2012
by
Frédéric Delanoy
Committed by
Alexandre Julliard
Nov 16, 2012
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
msi: Fix leaks in ITERATE_InstallService (coverity).
parent
cac26d47
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
6 additions
and
2 deletions
+6
-2
action.c
dlls/msi/action.c
+6
-2
No files found.
dlls/msi/action.c
View file @
098b3c72
...
...
@@ -5752,6 +5752,7 @@ static UINT ITERATE_InstallService(MSIRECORD *rec, LPVOID param)
LPWSTR
depends
=
NULL
,
pass
=
NULL
,
args
=
NULL
,
image_path
=
NULL
;
DWORD
serv_type
,
start_type
,
err_control
;
SERVICE_DESCRIPTIONW
sd
=
{
NULL
};
UINT
ret
=
ERROR_SUCCESS
;
comp
=
MSI_RecordGetString
(
rec
,
12
);
component
=
msi_get_loaded_component
(
package
,
comp
);
...
...
@@ -5809,7 +5810,10 @@ static UINT ITERATE_InstallService(MSIRECORD *rec, LPVOID param)
{
int
len
=
strlenW
(
file
->
TargetPath
)
+
strlenW
(
args
)
+
2
;
if
(
!
(
image_path
=
msi_alloc
(
len
*
sizeof
(
WCHAR
))))
return
ERROR_OUTOFMEMORY
;
{
ret
=
ERROR_OUTOFMEMORY
;
goto
done
;
}
strcpyW
(
image_path
,
file
->
TargetPath
);
strcatW
(
image_path
,
szSpace
);
...
...
@@ -5843,7 +5847,7 @@ done:
msi_free
(
depends
);
msi_free
(
args
);
return
ERROR_SUCCESS
;
return
ret
;
}
static
UINT
ACTION_InstallServices
(
MSIPACKAGE
*
package
)
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment