wintrust: Fix uninitialized return value (Coverity).

0f632c0c · Juan Lang · Alexandre Julliard · 08671181 · 0f632c0c
Commit 0f632c0c authored Feb 01, 2010 by Juan Lang Committed by Alexandre Julliard Feb 02, 2010
Hide whitespace changes
Inline Side-by-side

Showing with 1 addition and 6 deletions

softpub.c dlls/wintrust/softpub.c +1 -6

No files found.
--- a/dlls/wintrust/softpub.c
+++ b/dlls/wintrust/softpub.c
@@ -284,7 +284,7 @@ error:

 static DWORD SOFTPUB_LoadCertMessage(CRYPT_PROVIDER_DATA *data)
 {
-    DWORD err;
+    DWORD err = ERROR_SUCCESS;

    if (data->pWintrustData->u.pCert &&
     WVT_IS_CBSTRUCT_GT_MEMBEROFFSET(WINTRUST_CERT_INFO,
@@ -325,11 +325,6 @@ static DWORD SOFTPUB_LoadCertMessage(CRYPT_PROVIDER_DATA *data)
            if (!ret)
                err = GetLastError();
        }
-        else
-        {
-            /* Do nothing!?  See the tests */
-            err = ERROR_SUCCESS;
-        }
    }
    else
        err = ERROR_INVALID_PARAMETER;