Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
W
wine-winehq
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
wine
wine-winehq
Commits
0fe44e1b
Commit
0fe44e1b
authored
Apr 17, 2014
by
Marcus Meissner
Committed by
Alexandre Julliard
Apr 17, 2014
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
winhttp: Avoid leaking authinfo on error (Coverity).
parent
ccefbee7
Show whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
7 additions
and
1 deletion
+7
-1
request.c
dlls/winhttp/request.c
+7
-1
No files found.
dlls/winhttp/request.c
View file @
0fe44e1b
...
@@ -1628,7 +1628,11 @@ static BOOL do_authorization( request_t *request, DWORD target, DWORD scheme_fla
...
@@ -1628,7 +1628,11 @@ static BOOL do_authorization( request_t *request, DWORD target, DWORD scheme_fla
{
{
int
len
=
strlenW
(
++
p
);
int
len
=
strlenW
(
++
p
);
in
.
cbBuffer
=
decode_base64
(
p
,
len
,
NULL
);
in
.
cbBuffer
=
decode_base64
(
p
,
len
,
NULL
);
if
(
!
(
in
.
pvBuffer
=
heap_alloc
(
in
.
cbBuffer
)))
return
FALSE
;
if
(
!
(
in
.
pvBuffer
=
heap_alloc
(
in
.
cbBuffer
)))
{
destroy_authinfo
(
authinfo
);
*
auth_ptr
=
NULL
;
return
FALSE
;
}
decode_base64
(
p
,
len
,
in
.
pvBuffer
);
decode_base64
(
p
,
len
,
in
.
pvBuffer
);
}
}
out
.
BufferType
=
SECBUFFER_TOKEN
;
out
.
BufferType
=
SECBUFFER_TOKEN
;
...
@@ -1636,6 +1640,8 @@ static BOOL do_authorization( request_t *request, DWORD target, DWORD scheme_fla
...
@@ -1636,6 +1640,8 @@ static BOOL do_authorization( request_t *request, DWORD target, DWORD scheme_fla
if
(
!
(
out
.
pvBuffer
=
heap_alloc
(
authinfo
->
max_token
)))
if
(
!
(
out
.
pvBuffer
=
heap_alloc
(
authinfo
->
max_token
)))
{
{
heap_free
(
in
.
pvBuffer
);
heap_free
(
in
.
pvBuffer
);
destroy_authinfo
(
authinfo
);
*
auth_ptr
=
NULL
;
return
FALSE
;
return
FALSE
;
}
}
out_desc
.
ulVersion
=
0
;
out_desc
.
ulVersion
=
0
;
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment