Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
W
wine-winehq
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
wine
wine-winehq
Commits
12a77842
Commit
12a77842
authored
Sep 11, 2021
by
Eric Pouech
Committed by
Alexandre Julliard
Sep 14, 2021
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
dbghelp/dwarf: Handle errors in dwarf2_fill_attr by returning a boolean.
Signed-off-by:
Eric Pouech
<
eric.pouech@gmail.com
>
Signed-off-by:
Alexandre Julliard
<
julliard@winehq.org
>
parent
40877456
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
5 additions
and
5 deletions
+5
-5
dwarf.c
dlls/dbghelp/dwarf.c
+5
-5
No files found.
dlls/dbghelp/dwarf.c
View file @
12a77842
...
...
@@ -509,7 +509,7 @@ static void dwarf2_swallow_attribute(dwarf2_traverse_context_t* ctx,
ctx
->
data
+=
step
;
}
static
void
dwarf2_fill_attr
(
const
dwarf2_parse_context_t
*
ctx
,
static
BOOL
dwarf2_fill_attr
(
const
dwarf2_parse_context_t
*
ctx
,
const
dwarf2_abbrev_entry_attr_t
*
abbrev_attr
,
const
unsigned
char
*
data
,
struct
attribute
*
attr
)
...
...
@@ -637,6 +637,7 @@ static void dwarf2_fill_attr(const dwarf2_parse_context_t* ctx,
FIXME
(
"Unhandled attribute form %lx
\n
"
,
abbrev_attr
->
form
);
break
;
}
return
TRUE
;
}
static
BOOL
dwarf2_find_attribute
(
const
dwarf2_parse_context_t
*
ctx
,
...
...
@@ -655,8 +656,7 @@ static BOOL dwarf2_find_attribute(const dwarf2_parse_context_t* ctx,
{
if
(
abbrev_attr
->
attribute
==
at
)
{
dwarf2_fill_attr
(
ctx
,
abbrev_attr
,
di
->
data
[
i
],
attr
);
return
TRUE
;
return
dwarf2_fill_attr
(
ctx
,
abbrev_attr
,
di
->
data
[
i
],
attr
);
}
if
((
abbrev_attr
->
attribute
==
DW_AT_abstract_origin
||
abbrev_attr
->
attribute
==
DW_AT_specification
)
&&
...
...
@@ -671,8 +671,8 @@ static BOOL dwarf2_find_attribute(const dwarf2_parse_context_t* ctx,
}
}
/* do we have either an abstract origin or a specification debug entry to look into ? */
if
(
!
ref_abbrev_attr
)
break
;
dwarf2_fill_attr
(
ctx
,
ref_abbrev_attr
,
di
->
data
[
refidx
],
attr
)
;
if
(
!
ref_abbrev_attr
||
!
dwarf2_fill_attr
(
ctx
,
ref_abbrev_attr
,
di
->
data
[
refidx
],
attr
))
break
;
if
(
!
(
di
=
sparse_array_find
(
&
ctx
->
debug_info_table
,
attr
->
u
.
uvalue
)))
FIXME
(
"Should have found the debug info entry
\n
"
);
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment