- Don't crash on double InternetCloseHandle.

- Test case for this.

- Don't crash on double InternetCloseHandle.
12df80a7 · Robert Shearman · Alexandre Julliard · 64d69b60 · 12df80a7 · 12df80a7
Commit 12df80a7 authored Sep 23, 2004 by Robert Shearman Committed by Alexandre Julliard Sep 23, 2004
Show whitespace changes
Inline Side-by-side

Showing with 4 additions and 1 deletion

internet.c dlls/wininet/internet.c +2 -1

http.c dlls/wininet/tests/http.c +2 -0

No files found.
--- a/dlls/wininet/internet.c
+++ b/dlls/wininet/internet.c
@@ -192,7 +192,8 @@ LPWININETHANDLEHEADER WININET_GetObject( HINTERNET hinternet )

    EnterCriticalSection( &WININET_cs );

-    if( (handle > 0) && ( handle <= WININET_dwMaxHandles ) )
+    if( (handle > 0) && ( handle <= WININET_dwMaxHandles ) && 
+        WININET_Handles[handle-1] )
        info = WININET_AddRef( WININET_Handles[handle-1] );

    LeaveCriticalSection( &WININET_cs );

--- a/dlls/wininet/tests/http.c
+++ b/dlls/wininet/tests/http.c
@@ -195,6 +195,8 @@ abort:
    if (hor != 0x0) {
        rc = InternetCloseHandle(hor);
        ok ((rc != 0), "InternetCloseHandle of handle opened by HttpOpenRequestA failed\n");
+        rc = InternetCloseHandle(hor);
+        ok ((rc == 0), "Double close of handle opened by HttpOpenRequestA succeeded\n");
    }
    if (hic != 0x0) {
        rc = InternetCloseHandle(hic);