Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
W
wine-winehq
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
wine
wine-winehq
Commits
137030bf
Commit
137030bf
authored
Apr 10, 2016
by
Nikolay Sivov
Committed by
Alexandre Julliard
Apr 11, 2016
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
dwrite: Always return non-zero metrics for strikethrough/underline thickness.
Signed-off-by:
Nikolay Sivov
<
nsivov@codeweavers.com
>
Signed-off-by:
Alexandre Julliard
<
julliard@winehq.org
>
parent
f9444752
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
12 additions
and
2 deletions
+12
-2
opentype.c
dlls/dwrite/opentype.c
+12
-0
font.c
dlls/dwrite/tests/font.c
+0
-2
No files found.
dlls/dwrite/opentype.c
View file @
137030bf
...
...
@@ -1204,6 +1204,18 @@ void opentype_get_font_metrics(IDWriteFontFileStream *stream, DWRITE_FONT_FACE_T
metrics
->
underlineThickness
=
GET_BE_WORD
(
tt_post
->
underlineThickness
);
}
/* use any of thickness values if another one is zero, if both are zero use estimate */
if
(
metrics
->
strikethroughThickness
||
metrics
->
underlineThickness
)
{
if
(
!
metrics
->
strikethroughThickness
)
metrics
->
strikethroughThickness
=
metrics
->
underlineThickness
;
if
(
!
metrics
->
underlineThickness
)
metrics
->
underlineThickness
=
metrics
->
strikethroughThickness
;
}
else
{
metrics
->
strikethroughThickness
=
metrics
->
designUnitsPerEm
/
14
;
metrics
->
underlineThickness
=
metrics
->
designUnitsPerEm
/
14
;
}
/* estimate missing metrics */
if
(
metrics
->
xHeight
==
0
)
metrics
->
xHeight
=
metrics
->
designUnitsPerEm
/
2
;
...
...
dlls/dwrite/tests/font.c
View file @
137030bf
...
...
@@ -1576,12 +1576,10 @@ static void check_font_metrics(const WCHAR *nameW, const DWRITE_FONT_METRICS *go
wine_dbgstr_w
(
nameW
),
got
->
designUnitsPerEm
,
expected
->
designUnitsPerEm
);
ok
(
got
->
underlinePosition
==
expected
->
underlinePosition
,
"font %s: underlinePosition %d, expected %d
\n
"
,
wine_dbgstr_w
(
nameW
),
got
->
underlinePosition
,
expected
->
underlinePosition
);
todo_wine_if
(
got
->
underlineThickness
==
0
)
ok
(
got
->
underlineThickness
==
expected
->
underlineThickness
,
"font %s: underlineThickness %u, "
"expected %u
\n
"
,
wine_dbgstr_w
(
nameW
),
got
->
underlineThickness
,
expected
->
underlineThickness
);
ok
(
got
->
strikethroughPosition
==
expected
->
strikethroughPosition
,
"font %s: strikethroughPosition %d, expected %d
\n
"
,
wine_dbgstr_w
(
nameW
),
got
->
strikethroughPosition
,
expected
->
strikethroughPosition
);
todo_wine_if
(
got
->
strikethroughThickness
==
0
)
ok
(
got
->
strikethroughThickness
==
expected
->
strikethroughThickness
,
"font %s: strikethroughThickness %u, "
"expected %u
\n
"
,
wine_dbgstr_w
(
nameW
),
got
->
strikethroughThickness
,
expected
->
strikethroughThickness
);
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment