advapi32: Hold lock while handling service thread shutdown.

Signed-off-by: Sebastian Lackner <sebastian@fds-team.de> Signed-off-by: Alexandre Julliard <julliard@winehq.org>

advapi32: Hold lock while handling service thread shutdown.
13bb213a · Sebastian Lackner · Alexandre Julliard · 63c36da6 · 13bb213a
Commit 13bb213a authored Aug 17, 2016 by Sebastian Lackner Committed by Alexandre Julliard Aug 18, 2016
Hide whitespace changes
Inline Side-by-side

Showing with 5 additions and 2 deletions

service.c dlls/advapi32/service.c +5 -2

No files found.
--- a/dlls/advapi32/service.c
+++ b/dlls/advapi32/service.c
@@ -625,8 +625,11 @@ static BOOL service_run_main_thread(void)
        }
        else if (ret < n)
        {
-            services[wait_services[ret]]->thread = 0;
-            CloseHandle( wait_handles[ret] );
+            i = wait_services[ret];
+            EnterCriticalSection( &service_cs );
+            CloseHandle( services[i]->thread );
+            services[i]->thread = NULL;
+            LeaveCriticalSection( &service_cs );
        }
        else return FALSE;
    }