hidclass.sys: Fix some memory leaks on error path (Coverity).

Signed-off-by: Sven Baars <sven.wine@gmail.com> Signed-off-by: Alexandre Julliard <julliard@winehq.org>

hidclass.sys: Fix some memory leaks on error path (Coverity).
1413f577 · Sven Baars · Alexandre Julliard · b56d19d3 · 1413f577
Commit 1413f577 authored Sep 07, 2019 by Sven Baars Committed by Alexandre Julliard Sep 10, 2019
Hide whitespace changes
Inline Side-by-side

Showing with 6 additions and 0 deletions

pnp.c dlls/hidclass.sys/pnp.c +6 -0

No files found.
--- a/dlls/hidclass.sys/pnp.c
+++ b/dlls/hidclass.sys/pnp.c
@@ -123,6 +123,7 @@ NTSTATUS WINAPI PNP_AddDevice(DRIVER_OBJECT *driver, DEVICE_OBJECT *PDO)
    {
        ERR("Minidriver AddDevice failed (%x)\n",status);
        HID_DeleteDevice(device);
+        HeapFree(GetProcessHeap(), 0, hiddev);
        return status;
    }

@@ -133,6 +134,7 @@ NTSTATUS WINAPI PNP_AddDevice(DRIVER_OBJECT *driver, DEVICE_OBJECT *PDO)
    {
        ERR("Minidriver failed to get Attributes(%x)\n",status);
        HID_DeleteDevice(device);
+        HeapFree(GetProcessHeap(), 0, hiddev);
        return status;
    }

@@ -147,6 +149,7 @@ NTSTATUS WINAPI PNP_AddDevice(DRIVER_OBJECT *driver, DEVICE_OBJECT *PDO)
    {
        ERR("Cannot get Device Descriptor(%x)\n",status);
        HID_DeleteDevice(device);
+        HeapFree(GetProcessHeap(), 0, hiddev);
        return status;
    }
    for (i = 0; i < descriptor.bNumDescriptors; i++)
@@ -157,6 +160,7 @@ NTSTATUS WINAPI PNP_AddDevice(DRIVER_OBJECT *driver, DEVICE_OBJECT *PDO)
    {
        ERR("No Report Descriptor found in reply\n");
        HID_DeleteDevice(device);
+        HeapFree(GetProcessHeap(), 0, hiddev);
        return status;
    }

@@ -168,6 +172,7 @@ NTSTATUS WINAPI PNP_AddDevice(DRIVER_OBJECT *driver, DEVICE_OBJECT *PDO)
        ERR("Cannot get Report Descriptor(%x)\n",status);
        HID_DeleteDevice(device);
        HeapFree(GetProcessHeap(), 0, reportDescriptor);
+        HeapFree(GetProcessHeap(), 0, hiddev);
        return status;
    }

@@ -178,6 +183,7 @@ NTSTATUS WINAPI PNP_AddDevice(DRIVER_OBJECT *driver, DEVICE_OBJECT *PDO)
    {
        ERR("Cannot parse Report Descriptor\n");
        HID_DeleteDevice(device);
+        HeapFree(GetProcessHeap(), 0, hiddev);
        return STATUS_NOT_SUPPORTED;
    }