dsound: Check for invalid parameter when unlocking primary buffers.

14db7003 · Jeff Zaroyko · Alexandre Julliard · 73393fab · 14db7003
Commit 14db7003 authored Jan 02, 2009 by Jeff Zaroyko Committed by Alexandre Julliard Jan 02, 2009
Show whitespace changes
Inline Side-by-side

Showing with 4 additions and 0 deletions

primary.c dlls/dsound/primary.c +4 -0

No files found.
--- a/dlls/dsound/primary.c
+++ b/dlls/dsound/primary.c
@@ -1000,7 +1000,11 @@ static HRESULT WINAPI PrimaryBufferImpl_Unlock(
 	if (!(device->drvdesc.dwFlags & DSDDESC_DONTNEEDPRIMARYLOCK) && device->hwbuf) {
 		HRESULT	hres;

+		if ((char *)p1 - (char *)device->buffer + x1 > device->buflen)
+		    hres = DSERR_INVALIDPARAM;
+		else
 		    hres = IDsDriverBuffer_Unlock(device->hwbuf, p1, x1, p2, x2);
+
 		if (hres != DS_OK) {
 			WARN("IDsDriverBuffer_Unlock failed\n");
 			return hres;