Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
W
wine-winehq
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
wine
wine-winehq
Commits
14e074b2
Commit
14e074b2
authored
Nov 26, 2019
by
Nikolay Sivov
Committed by
Alexandre Julliard
Nov 26, 2019
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
user32/combo: Remove redundant argument from text height helper.
Signed-off-by:
Nikolay Sivov
<
nsivov@codeweavers.com
>
Signed-off-by:
Alexandre Julliard
<
julliard@winehq.org
>
parent
13d7cad9
Show whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
8 additions
and
10 deletions
+8
-10
combo.c
dlls/user32/combo.c
+8
-10
No files found.
dlls/user32/combo.c
View file @
14e074b2
...
...
@@ -193,9 +193,7 @@ static LRESULT COMBO_NCDestroy( LPHEADCOMBO lphc )
* This height was determined through experimentation.
* CBCalcPlacement will add 2*COMBO_YBORDERSIZE pixels for the border
*/
static
INT
CBGetTextAreaHeight
(
HWND
hwnd
,
LPHEADCOMBO
lphc
)
static
INT
CBGetTextAreaHeight
(
HEADCOMBO
*
lphc
)
{
INT
iTextItemHeight
;
...
...
@@ -206,7 +204,7 @@ static INT CBGetTextAreaHeight(
else
{
TEXTMETRICW
tm
;
HDC
hDC
=
GetDC
(
hwnd
);
HDC
hDC
=
GetDC
(
lphc
->
self
);
HFONT
hPrevFont
=
0
;
INT
baseUnitY
;
...
...
@@ -220,7 +218,7 @@ static INT CBGetTextAreaHeight(
if
(
hPrevFont
)
SelectObject
(
hDC
,
hPrevFont
);
ReleaseDC
(
hwnd
,
hDC
);
ReleaseDC
(
lphc
->
self
,
hDC
);
iTextItemHeight
=
baseUnitY
+
4
;
}
...
...
@@ -240,7 +238,7 @@ static INT CBGetTextAreaHeight(
/*
* We use the client rect for the width of the item.
*/
GetClientRect
(
hwnd
,
&
clientRect
);
GetClientRect
(
lphc
->
self
,
&
clientRect
);
lphc
->
wState
&=
~
CBF_MEASUREITEM
;
...
...
@@ -294,7 +292,7 @@ static void CBForceDummyResize(
RECT
windowRect
;
int
newComboHeight
;
newComboHeight
=
CBGetTextAreaHeight
(
lphc
->
self
,
lphc
)
+
2
*
COMBO_YBORDERSIZE
();
newComboHeight
=
CBGetTextAreaHeight
(
lphc
)
+
2
*
COMBO_YBORDERSIZE
();
GetWindowRect
(
lphc
->
self
,
&
windowRect
);
...
...
@@ -328,7 +326,7 @@ static void CBCalcPlacement(HEADCOMBO *combo)
InflateRect
(
&
combo
->
textRect
,
-
COMBO_XBORDERSIZE
(),
-
COMBO_YBORDERSIZE
());
/* Chop off the bottom part to fit with the height of the text area. */
combo
->
textRect
.
bottom
=
combo
->
textRect
.
top
+
CBGetTextAreaHeight
(
combo
->
self
,
combo
);
combo
->
textRect
.
bottom
=
combo
->
textRect
.
top
+
CBGetTextAreaHeight
(
combo
);
/* The button starts the same vertical position as the text area. */
combo
->
buttonRect
=
combo
->
textRect
;
...
...
@@ -1455,7 +1453,7 @@ static void COMBO_Size( LPHEADCOMBO lphc )
GetWindowRect
(
lphc
->
self
,
&
rc
);
curComboHeight
=
rc
.
bottom
-
rc
.
top
;
curComboWidth
=
rc
.
right
-
rc
.
left
;
newComboHeight
=
CBGetTextAreaHeight
(
lphc
->
self
,
lphc
)
+
2
*
COMBO_YBORDERSIZE
();
newComboHeight
=
CBGetTextAreaHeight
(
lphc
)
+
2
*
COMBO_YBORDERSIZE
();
/*
* Resizing a combobox has another side effect, it resizes the dropped
...
...
@@ -2004,7 +2002,7 @@ LRESULT ComboWndProc_common( HWND hwnd, UINT message, WPARAM wParam, LPARAM lPar
case
CB_GETITEMHEIGHT
:
if
(
(
INT
)
wParam
>=
0
)
/* listbox item */
return
SendMessageW
(
lphc
->
hWndLBox
,
LB_GETITEMHEIGHT
,
wParam
,
0
);
return
CBGetTextAreaHeight
(
hwnd
,
lphc
);
return
CBGetTextAreaHeight
(
lphc
);
case
CB_RESETCONTENT
:
SendMessageW
(
lphc
->
hWndLBox
,
LB_RESETCONTENT
,
0
,
0
);
if
(
(
lphc
->
wState
&
CBF_EDIT
)
&&
CB_HASSTRINGS
(
lphc
)
)
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment