Fix memory leak in OleDuplicateData on error path (found by Smatch).

1571df57 · Robert Shearman · Alexandre Julliard · 11f2cb18 · 1571df57
Commit 1571df57 authored Mar 19, 2005 by Robert Shearman Committed by Alexandre Julliard Mar 19, 2005
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 3 deletions

ole2impl.c dlls/ole32/ole2impl.c +2 -3

No files found.
--- a/dlls/ole32/ole2impl.c
+++ b/dlls/ole32/ole2impl.c
@@ -259,9 +259,8 @@ HANDLE WINAPI OleDuplicateData(HANDLE hSrc, CLIPFORMAT cfFormat,
            if (!size) return NULL;
            bm.bmBits = HeapAlloc(GetProcessHeap(), 0, size);
            if (!bm.bmBits) return NULL;
-            if (!GetBitmapBits(hSrc, size, bm.bmBits))
+            if (GetBitmapBits(hSrc, size, bm.bmBits))
-                return NULL;
+                hDst = CreateBitmapIndirect(&bm);
-            hDst = CreateBitmapIndirect(&bm);
            HeapFree(GetProcessHeap(), 0, bm.bmBits);
            break;
        }