Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
W
wine-winehq
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
wine
wine-winehq
Commits
15c00627
Commit
15c00627
authored
Jun 16, 2023
by
Alex Henrie
Committed by
Alexandre Julliard
Jun 19, 2023
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
comdlg32: Don't use GetProcAddress for SHSimpleIDListFromPath.
The function is exported by name from shell32 and declared in a public header.
parent
2c235b6f
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
1 addition
and
22 deletions
+1
-22
cdlg.h
dlls/comdlg32/cdlg.h
+0
-3
cdlg32.c
dlls/comdlg32/cdlg32.c
+0
-18
itemdlg.c
dlls/comdlg32/itemdlg.c
+1
-1
No files found.
dlls/comdlg32/cdlg.h
View file @
15c00627
...
...
@@ -182,9 +182,6 @@ void FILEDLG95_OnOpenMessage(HWND hwnd, int idCaption, int idText) DECLSPEC_HIDD
extern
BOOL
GetFileName31A
(
OPENFILENAMEA
*
lpofn
,
UINT
dlgType
)
DECLSPEC_HIDDEN
;
extern
BOOL
GetFileName31W
(
OPENFILENAMEW
*
lpofn
,
UINT
dlgType
)
DECLSPEC_HIDDEN
;
/* SHELL */
extern
LPITEMIDLIST
(
WINAPI
*
COMDLG32_SHSimpleIDListFromPathAW
)(
LPCVOID
);
#define ONOPEN_BROWSE 1
#define ONOPEN_OPEN 2
#define ONOPEN_SEARCH 3
...
...
dlls/comdlg32/cdlg32.c
View file @
15c00627
...
...
@@ -43,11 +43,6 @@ DECLSPEC_HIDDEN HINSTANCE COMDLG32_hInstance = 0;
static
DWORD
COMDLG32_TlsIndex
=
TLS_OUT_OF_INDEXES
;
static
HINSTANCE
SHELL32_hInstance
;
/* SHELL */
LPITEMIDLIST
(
WINAPI
*
COMDLG32_SHSimpleIDListFromPathAW
)(
LPCVOID
)
DECLSPEC_HIDDEN
;
/***********************************************************************
* DllMain (COMDLG32.init)
*
...
...
@@ -57,14 +52,6 @@ LPITEMIDLIST (WINAPI *COMDLG32_SHSimpleIDListFromPathAW)(LPCVOID) DECLSPEC_HIDDE
* FALSE if sibling could not be loaded or instantiated twice, TRUE
* otherwise.
*/
static
const
char
GPA_string
[]
=
"Failed to get entry point %s for hinst = %p
\n
"
;
#define GPA(dest, hinst, name) \
if(!(dest = (void*)GetProcAddress(hinst,name)))\
{ \
ERR(GPA_string, debugstr_a(name), hinst); \
return FALSE; \
}
BOOL
WINAPI
DllMain
(
HINSTANCE
hInstance
,
DWORD
Reason
,
LPVOID
Reserved
)
{
TRACE
(
"(%p, %ld, %p)
\n
"
,
hInstance
,
Reason
,
Reserved
);
...
...
@@ -74,11 +61,6 @@ BOOL WINAPI DllMain(HINSTANCE hInstance, DWORD Reason, LPVOID Reserved)
case
DLL_PROCESS_ATTACH
:
COMDLG32_hInstance
=
hInstance
;
DisableThreadLibraryCalls
(
hInstance
);
SHELL32_hInstance
=
GetModuleHandleA
(
"SHELL32.DLL"
);
/* SHELL */
GPA
(
COMDLG32_SHSimpleIDListFromPathAW
,
SHELL32_hInstance
,
(
LPCSTR
)
162
);
break
;
case
DLL_PROCESS_DETACH
:
...
...
dlls/comdlg32/itemdlg.c
View file @
15c00627
...
...
@@ -599,7 +599,7 @@ static HRESULT on_default_action(FileDialogImpl *This)
}
}
pidla
[
i
]
=
COMDLG32_SHSimpleIDListFromPathAW
(
canon_filename
);
pidla
[
i
]
=
SHSimpleIDListFromPath
(
canon_filename
);
if
(
psf_parent
&&
!
(
open_action
==
ONOPEN_BROWSE
))
IShellFolder_Release
(
psf_parent
);
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment