msi: Check the return value of MSI_QueryGetRecord (Coverity).

17405f6b · Hans Leidekker · Alexandre Julliard · e94d9770 · 17405f6b
Commit 17405f6b authored Jul 15, 2015 by Hans Leidekker Committed by Alexandre Julliard Jul 15, 2015
Show whitespace changes
Inline Side-by-side

Showing with 3 additions and 1 deletion

action.c dlls/msi/action.c +3 -1

No files found.
--- a/dlls/msi/action.c
+++ b/dlls/msi/action.c
@@ -3554,7 +3554,9 @@ static UINT ACTION_ProcessComponents(MSIPACKAGE *package)
                if (!comp->KeyPath || !(file = msi_get_loaded_file(package, comp->KeyPath)))
                    continue;

-                row = MSI_QueryGetRecord(package->db, query, file->Sequence);
+                if (!(row = MSI_QueryGetRecord(package->db, query, file->Sequence)))
+                    return ERROR_FUNCTION_FAILED;
+
                sprintfW(source, fmt, MSI_RecordGetInteger(row, 1));
                ptr2 = strrchrW(source, '\\') + 1;
                msiobj_release(&row->hdr);