Multiple *ptr++ constructs in one expression have undefined behaviour,

moved them out of the expression.

Multiple *ptr++ constructs in one expression have undefined behaviour,
183eae90 · Marcus Meissner · Alexandre Julliard · dae8de69 · 183eae90
Commit 183eae90 authored Jun 14, 2001 by Marcus Meissner Committed by Alexandre Julliard Jun 14, 2001
Hide whitespace changes
Inline Side-by-side

Showing with 5 additions and 4 deletions

dib.c objects/dib.c +5 -4

No files found.
--- a/objects/dib.c
+++ b/objects/dib.c
@@ -559,10 +559,11 @@ INT WINAPI GetDIBits(
                            LPBYTE srcbits = sbits;

                            for( y = 0; y < lines; y++) {
-                                for( x = 0; x < srcwidth; x++ )
-                                    *dstbits++ = ((*srcbits++ >> 3) & bmask) |
-                                                 (((WORD)*srcbits++ << 2) & gmask) |
-                                                 (((WORD)*srcbits++ << 7) & rmask);
+                                for( x = 0; x < srcwidth; x++, srcbits += 3)
+                                    *dstbits++ = ((srcbits[0] >> 3) & bmask) |
+                                                 (((WORD)srcbits[1] << 2) & gmask) |
+                                                 (((WORD)srcbits[2] << 7) & rmask);
+
                                dstbits = (LPWORD)(dbits+=dstwidthb);
                                srcbits = (sbits += srcwidthb);
                            }