dplayx: Prevent out-of-bounds access to lpMemArea.

Based on a patch by Andrey Gusev. Signed-off-by: Huw Davies <huw@codeweavers.com> Signed-off-by: Alistair Leslie-Hughes <leslie_alistair@hotmail.com> Signed-off-by: Alexandre Julliard <julliard@winehq.org>

dplayx: Prevent out-of-bounds access to lpMemArea.
18e532d6 · Huw Davies · Alexandre Julliard · 8d044482 · 18e532d6
Commit 18e532d6 authored May 30, 2018 by Huw Davies Committed by Alexandre Julliard May 31, 2018
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 2 deletions

dplayx_global.c dlls/dplayx/dplayx_global.c +2 -2

No files found.
--- a/dlls/dplayx/dplayx_global.c
+++ b/dlls/dplayx/dplayx_global.c
@@ -120,9 +120,9 @@ static LPVOID DPLAYX_PrivHeapAlloc( DWORD flags, DWORD size )

  /* Find blank area */
  uBlockUsed = 0;
-  while( lpMemArea[ uBlockUsed ].used && uBlockUsed <= dwMaxBlock ) { uBlockUsed++; }
+  while( uBlockUsed < dwMaxBlock && lpMemArea[ uBlockUsed ].used ) { uBlockUsed++; }

-  if( uBlockUsed <= dwMaxBlock )
+  if( uBlockUsed < dwMaxBlock )
  {
    /* Set the area used */
    lpMemArea[ uBlockUsed ].used = TRUE;