Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
W
wine-winehq
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
wine
wine-winehq
Commits
190762cb
Commit
190762cb
authored
Jun 26, 2020
by
Jacek Caban
Committed by
Alexandre Julliard
Jun 26, 2020
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
mshtml: Use variant_to_nsstr in IHTMLIFrameElement2::put_height.
Signed-off-by:
Jacek Caban
<
jacek@codeweavers.com
>
Signed-off-by:
Alexandre Julliard
<
julliard@winehq.org
>
parent
84acd2f4
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
15 additions
and
6 deletions
+15
-6
htmlframe.c
dlls/mshtml/htmlframe.c
+4
-5
dom.c
dlls/mshtml/tests/dom.c
+11
-1
No files found.
dlls/mshtml/htmlframe.c
View file @
190762cb
...
...
@@ -1240,15 +1240,14 @@ static HRESULT WINAPI HTMLIFrameElement2_put_height(IHTMLIFrameElement2 *iface,
HTMLIFrame
*
This
=
impl_from_IHTMLIFrameElement2
(
iface
);
nsAString
nsstr
;
nsresult
nsres
;
HRESULT
hres
;
TRACE
(
"(%p)->(%s)
\n
"
,
This
,
debugstr_variant
(
&
v
));
if
(
V_VT
(
&
v
)
!=
VT_BSTR
)
{
FIXME
(
"Unsupported %s
\n
"
,
debugstr_variant
(
&
v
));
return
E_NOTIMPL
;
}
hres
=
variant_to_nsstr
(
&
v
,
FALSE
,
&
nsstr
);
if
(
FAILED
(
hres
))
return
hres
;
nsAString_InitDepend
(
&
nsstr
,
V_BSTR
(
&
v
));
nsres
=
nsIDOMHTMLIFrameElement_SetHeight
(
This
->
framebase
.
nsiframe
,
&
nsstr
);
nsAString_Finish
(
&
nsstr
);
if
(
NS_FAILED
(
nsres
))
{
...
...
dlls/mshtml/tests/dom.c
View file @
190762cb
...
...
@@ -8205,12 +8205,13 @@ static void _set_iframe_width(unsigned line, IHTMLElement *elem, const WCHAR *va
static
void
test_iframe_elem
(
IHTMLElement
*
elem
)
{
IHTMLDocument2
*
content_doc
,
*
owner_doc
;
IHTMLIFrameElement2
*
iframe2
;
IHTMLIFrameElement3
*
iframe3
;
IHTMLElementCollection
*
col
;
IHTMLWindow2
*
content_window
;
IHTMLElement
*
body
;
IDispatch
*
disp
;
VARIANT
errv
;
VARIANT
errv
,
v
;
BSTR
str
;
HRESULT
hres
;
...
...
@@ -8244,11 +8245,19 @@ static void test_iframe_elem(IHTMLElement *elem)
win_skip
(
"IHTMLIFrameElement3 not supported
\n
"
);
}
iframe2
=
get_iframe2_iface
((
IUnknown
*
)
elem
);
test_iframe_height
(
elem
,
NULL
);
set_iframe_height
(
elem
,
L"100px"
);
set_iframe_height
(
elem
,
L"50%"
);
test_iframe_height
(
elem
,
L"50%"
);
V_VT
(
&
v
)
=
VT_I4
;
V_I4
(
&
v
)
=
100
;
hres
=
IHTMLIFrameElement2_put_height
(
iframe2
,
v
);
ok
(
hres
==
S_OK
,
"put_height failed: %08x
\n
"
,
hres
);
test_iframe_height
(
elem
,
L"100"
);
test_iframe_width
(
elem
,
NULL
);
set_iframe_width
(
elem
,
L"150px"
);
set_iframe_width
(
elem
,
L"70%"
);
...
...
@@ -8279,6 +8288,7 @@ static void test_iframe_elem(IHTMLElement *elem)
test_elem_attr
(
body
,
L"i4val"
,
L"4"
);
test_elem_attr
(
body
,
L"r8val"
,
L"3.14"
);
IHTMLElement_Release
(
body
);
IHTMLIFrameElement2_Release
(
iframe2
);
hres
=
IHTMLDocument2_close
(
content_doc
);
ok
(
hres
==
S_OK
,
"close failed: %08x
\n
"
,
hres
);
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment