mciqtz32: Don't overflow seek times during multiplication.

Seek times are of type REFERENCE_TIME (64-bit), but the multiplication is done in DWORD (32-bit). Signed-off-by: Lukáš Krejčí <lskrejci@gmail.com> Signed-off-by: Alexandre Julliard <julliard@winehq.org>

mciqtz32: Don't overflow seek times during multiplication.
1d9a3f6d · Lukáš Krejčí · Alexandre Julliard · 13e11d3f · 1d9a3f6d
Commit 1d9a3f6d authored May 29, 2019 by Lukáš Krejčí Committed by Alexandre Julliard May 30, 2019
Hide whitespace changes
Inline Side-by-side

Showing with 5 additions and 6 deletions

mciqtz.c dlls/mciqtz32/mciqtz.c +5 -6

No files found.
--- a/dlls/mciqtz32/mciqtz.c
+++ b/dlls/mciqtz32/mciqtz.c
@@ -422,20 +422,19 @@ static DWORD MCIQTZ_mciPlay(UINT wDevID, DWORD dwFlags, LPMCI_PLAY_PARMS lpParms
    wma->mci_flags = dwFlags;
    IMediaSeeking_GetTimeFormat(wma->seek, &format);
    if (dwFlags & MCI_FROM) {
+        wma->seek_start = lpParms->dwFrom;
        if (IsEqualGUID(&format, &TIME_FORMAT_MEDIA_TIME))
-            wma->seek_start = lpParms->dwFrom * 10000;
-        else
-            wma->seek_start = lpParms->dwFrom;
+            wma->seek_start *= 10000;
+
        start_flags = AM_SEEKING_AbsolutePositioning;
    } else {
        wma->seek_start = 0;
        start_flags = AM_SEEKING_NoPositioning;
    }
    if (dwFlags & MCI_TO) {
+        wma->seek_stop = lpParms->dwTo;
        if (IsEqualGUID(&format, &TIME_FORMAT_MEDIA_TIME))
-            wma->seek_stop = lpParms->dwTo * 10000;
-        else
-            wma->seek_stop = lpParms->dwTo;
+            wma->seek_stop *= 10000;
    } else {
        wma->seek_stop = 0;
        IMediaSeeking_GetDuration(wma->seek, &wma->seek_stop);