Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
W
wine-winehq
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
wine
wine-winehq
Commits
1def41b9
Commit
1def41b9
authored
Jan 22, 2018
by
Huw Davies
Committed by
Alexandre Julliard
Jan 22, 2018
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
gdi32: Don't bother using the return value of HeapFree().
Signed-off-by:
Huw Davies
<
huw@codeweavers.com
>
Signed-off-by:
Alexandre Julliard
<
julliard@winehq.org
>
parent
8bdcaf60
Show whitespace changes
Inline
Side-by-side
Showing
9 changed files
with
19 additions
and
9 deletions
+19
-9
bitmap.c
dlls/gdi32/bitmap.c
+2
-1
brush.c
dlls/gdi32/brush.c
+2
-1
dib.c
dlls/gdi32/dib.c
+2
-1
opengl.c
dlls/gdi32/dibdrv/opengl.c
+2
-1
enhmetafile.c
dlls/gdi32/enhmetafile.c
+2
-1
font.c
dlls/gdi32/font.c
+2
-1
metafile.c
dlls/gdi32/metafile.c
+3
-1
palette.c
dlls/gdi32/palette.c
+2
-1
pen.c
dlls/gdi32/pen.c
+2
-1
No files found.
dlls/gdi32/bitmap.c
View file @
1def41b9
...
...
@@ -489,7 +489,8 @@ static BOOL BITMAP_DeleteObject( HGDIOBJ handle )
if
(
!
bmp
)
return
FALSE
;
HeapFree
(
GetProcessHeap
(),
0
,
bmp
->
dib
.
dsBm
.
bmBits
);
return
HeapFree
(
GetProcessHeap
(),
0
,
bmp
);
HeapFree
(
GetProcessHeap
(),
0
,
bmp
);
return
TRUE
;
}
...
...
dlls/gdi32/brush.c
View file @
1def41b9
...
...
@@ -467,7 +467,8 @@ static BOOL BRUSH_DeleteObject( HGDIOBJ handle )
if
(
!
brush
)
return
FALSE
;
free_brush_pattern
(
&
brush
->
pattern
);
return
HeapFree
(
GetProcessHeap
(),
0
,
brush
);
HeapFree
(
GetProcessHeap
(),
0
,
brush
);
return
TRUE
;
}
...
...
dlls/gdi32/dib.c
View file @
1def41b9
...
...
@@ -1831,5 +1831,6 @@ static BOOL DIB_DeleteObject( HGDIOBJ handle )
else
VirtualFree
(
bmp
->
dib
.
dsBm
.
bmBits
,
0
,
MEM_RELEASE
);
HeapFree
(
GetProcessHeap
(),
0
,
bmp
->
color_table
);
return
HeapFree
(
GetProcessHeap
(),
0
,
bmp
);
HeapFree
(
GetProcessHeap
(),
0
,
bmp
);
return
TRUE
;
}
dlls/gdi32/dibdrv/opengl.c
View file @
1def41b9
...
...
@@ -217,7 +217,8 @@ static struct wgl_context *dibdrv_wglCreateContext( HDC hdc )
static
BOOL
dibdrv_wglDeleteContext
(
struct
wgl_context
*
context
)
{
pOSMesaDestroyContext
(
context
->
context
);
return
HeapFree
(
GetProcessHeap
(),
0
,
context
);
HeapFree
(
GetProcessHeap
(),
0
,
context
);
return
TRUE
;
}
/***********************************************************************
...
...
dlls/gdi32/enhmetafile.c
View file @
1def41b9
...
...
@@ -287,7 +287,8 @@ static BOOL EMF_Delete_HENHMETAFILE( HENHMETAFILE hmf )
UnmapViewOfFile
(
metaObj
->
emh
);
else
HeapFree
(
GetProcessHeap
(),
0
,
metaObj
->
emh
);
return
HeapFree
(
GetProcessHeap
(),
0
,
metaObj
);
HeapFree
(
GetProcessHeap
(),
0
,
metaObj
);
return
TRUE
;
}
/******************************************************************
...
...
dlls/gdi32/font.c
View file @
1def41b9
...
...
@@ -811,7 +811,8 @@ static BOOL FONT_DeleteObject( HGDIOBJ handle )
FONTOBJ
*
obj
;
if
(
!
(
obj
=
free_gdi_handle
(
handle
)))
return
FALSE
;
return
HeapFree
(
GetProcessHeap
(),
0
,
obj
);
HeapFree
(
GetProcessHeap
(),
0
,
obj
);
return
TRUE
;
}
...
...
dlls/gdi32/metafile.c
View file @
1def41b9
...
...
@@ -135,8 +135,10 @@ static POINT *convert_points( UINT count, const POINTS *pts )
BOOL
WINAPI
DeleteMetaFile
(
HMETAFILE
hmf
)
{
METAHEADER
*
mh
=
free_gdi_handle
(
hmf
);
if
(
!
mh
)
return
FALSE
;
return
HeapFree
(
GetProcessHeap
(),
0
,
mh
);
HeapFree
(
GetProcessHeap
(),
0
,
mh
);
return
TRUE
;
}
/******************************************************************
...
...
dlls/gdi32/palette.c
View file @
1def41b9
...
...
@@ -610,7 +610,8 @@ static BOOL PALETTE_DeleteObject( HGDIOBJ handle )
PALETTE_UnrealizeObject
(
handle
);
if
(
!
(
obj
=
free_gdi_handle
(
handle
)))
return
FALSE
;
HeapFree
(
GetProcessHeap
(),
0
,
obj
->
entries
);
return
HeapFree
(
GetProcessHeap
(),
0
,
obj
);
HeapFree
(
GetProcessHeap
(),
0
,
obj
);
return
TRUE
;
}
...
...
dlls/gdi32/pen.c
View file @
1def41b9
...
...
@@ -279,7 +279,8 @@ static BOOL PEN_DeleteObject( HGDIOBJ handle )
if
(
!
pen
)
return
FALSE
;
free_brush_pattern
(
&
pen
->
pattern
);
return
HeapFree
(
GetProcessHeap
(),
0
,
pen
);
HeapFree
(
GetProcessHeap
(),
0
,
pen
);
return
TRUE
;
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment