windowscodecs: Fix a memory leak (Valgrind).

Signed-off-by: Sven Baars <sven.wine@gmail.com> Signed-off-by: Vincent Povirk <vincent@codeweavers.com> Signed-off-by: Alexandre Julliard <julliard@winehq.org>

windowscodecs: Fix a memory leak (Valgrind).
1f132865 · Sven Baars · Alexandre Julliard · 8aefa871 · 1f132865
Commit 1f132865 authored Jan 24, 2019 by Sven Baars Committed by Alexandre Julliard Jan 25, 2019
Hide whitespace changes
Inline Side-by-side

Showing with 3 additions and 1 deletion

pngformat.c dlls/windowscodecs/pngformat.c +3 -1

No files found.
--- a/dlls/windowscodecs/pngformat.c
+++ b/dlls/windowscodecs/pngformat.c
@@ -620,7 +620,6 @@ static HRESULT WINAPI PngDecoder_Initialize(IWICBitmapDecoder *iface, IStream *p
    if (setjmp(jmpbuf))
    {
        ppng_destroy_read_struct(&This->png_ptr, &This->info_ptr, &This->end_info);
-        HeapFree(GetProcessHeap(), 0, row_pointers);
        This->png_ptr = NULL;
        hr = WINCODEC_ERR_UNKNOWNIMAGEFORMAT;
        goto end;
@@ -816,6 +815,9 @@ static HRESULT WINAPI PngDecoder_Initialize(IWICBitmapDecoder *iface, IStream *p
 end:
    LeaveCriticalSection(&This->lock);

+    if (row_pointers)
+        HeapFree(GetProcessHeap(), 0, row_pointers);
+
    return hr;
 }