d3dcompiler: Iterate through the instruction list in reverse in free_instr_list() (Valgrind).

Signed-off-by: Zebediah Figura <z.figura12@gmail.com> Signed-off-by: Matteo Bruni <mbruni@codeweavers.com> Signed-off-by: Alexandre Julliard <julliard@winehq.org>

d3dcompiler: Iterate through the instruction list in reverse in free_instr_list() (Valgrind).
23cc3003 · Zebediah Figura · Alexandre Julliard · cb8de48f · 23cc3003
Commit 23cc3003 authored Aug 10, 2020 by Zebediah Figura Committed by Alexandre Julliard Aug 10, 2020
Show whitespace changes
Inline Side-by-side

Showing with 3 additions and 1 deletion

utils.c dlls/d3dcompiler_43/utils.c +3 -1

No files found.
--- a/dlls/d3dcompiler_43/utils.c
+++ b/dlls/d3dcompiler_43/utils.c
@@ -2113,7 +2113,9 @@ void free_instr_list(struct list *list)
    if (!list)
        return;
-    LIST_FOR_EACH_ENTRY_SAFE(node, next_node, list, struct hlsl_ir_node, entry)
+    /* Iterate in reverse, to avoid use-after-free when unlinking sources from
+     * the "uses" list. */
+    LIST_FOR_EACH_ENTRY_SAFE_REV(node, next_node, list, struct hlsl_ir_node, entry)
        free_instr(node);
    d3dcompiler_free(list);
 }