riched20: Handle range method failures in InRange (Coverity).

26883637 · Nikolay Sivov · Alexandre Julliard · 3889dadc · 26883637
Commit 26883637 authored Jun 07, 2015 by Nikolay Sivov Committed by Alexandre Julliard Jun 08, 2015
Hide whitespace changes
Inline Side-by-side

Showing with 5 additions and 4 deletions

richole.c dlls/riched20/richole.c +5 -4

No files found.
--- a/dlls/riched20/richole.c
+++ b/dlls/riched20/richole.c
@@ -2006,10 +2006,11 @@ static HRESULT textrange_inrange(LONG start, LONG end, ITextRange *range, LONG *
    if (!ret)
        ret = &v;

-    ITextRange_GetStart(range, &from);
-    ITextRange_GetEnd(range, &to);
-
-    *ret = (start >= from && end <= to) ? tomTrue : tomFalse;
+    if (FAILED(ITextRange_GetStart(range, &from)) || FAILED(ITextRange_GetEnd(range, &to))) {
+        *ret = tomFalse;
+    }
+    else
+        *ret = (start >= from && end <= to) ? tomTrue : tomFalse;
    return *ret == tomTrue ? S_OK : S_FALSE;
 }