Commit 2752da05 authored by Hans Leidekker's avatar Hans Leidekker Committed by Alexandre Julliard

winhttp: Ignore empty proxy strings read from the environment.

parent 5bc81188
......@@ -1597,29 +1597,21 @@ BOOL WINAPI WinHttpGetDefaultProxyConfiguration( WINHTTP_PROXY_INFO *info )
}
if (!got_from_reg && (envproxy = getenv( "http_proxy" )))
{
char *colon, *http_proxy;
char *colon, *http_proxy = NULL;
if ((colon = strchr( envproxy, ':' )))
if (!(colon = strchr( envproxy, ':' ))) http_proxy = envproxy;
else
{
if (*(colon + 1) == '/' && *(colon + 2) == '/')
{
static const char http[] = "http://";
/* It's a scheme, check that it's http */
if (!strncmp( envproxy, http, strlen( http ) ))
http_proxy = envproxy + strlen( http );
else
{
WARN("unsupported scheme in $http_proxy: %s\n", envproxy);
http_proxy = NULL;
if (!strncmp( envproxy, "http://", 7 )) http_proxy = envproxy + 7;
else WARN("unsupported scheme in $http_proxy: %s\n", envproxy);
}
else http_proxy = envproxy;
}
else
http_proxy = envproxy;
}
else
http_proxy = envproxy;
if (http_proxy)
if (http_proxy && http_proxy[0])
{
WCHAR *http_proxyW;
int len;
......@@ -1632,8 +1624,7 @@ BOOL WINAPI WinHttpGetDefaultProxyConfiguration( WINHTTP_PROXY_INFO *info )
info->dwAccessType = WINHTTP_ACCESS_TYPE_NAMED_PROXY;
info->lpszProxy = http_proxyW;
info->lpszProxyBypass = NULL;
TRACE("http proxy (from environment) = %s\n",
debugstr_w(info->lpszProxy));
TRACE("http proxy (from environment) = %s\n", debugstr_w(info->lpszProxy));
}
}
}
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment