Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
W
wine-winehq
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
wine
wine-winehq
Commits
27e9a983
Commit
27e9a983
authored
Oct 07, 2008
by
Michael Karcher
Committed by
Alexandre Julliard
Oct 07, 2008
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
msxml3: replaceNode accepts IXMLDOMElement instead of IXMLDOMNode.
parent
6fe686f5
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
16 additions
and
2 deletions
+16
-2
node.c
dlls/msxml3/node.c
+8
-1
domdoc.c
dlls/msxml3/tests/domdoc.c
+8
-1
No files found.
dlls/msxml3/node.c
View file @
27e9a983
...
...
@@ -613,6 +613,8 @@ static HRESULT WINAPI xmlnode_replaceChild(
xmlNode
*
old_child_ptr
,
*
new_child_ptr
;
xmlDocPtr
leaving_doc
;
xmlNode
*
my_ancestor
;
IXMLDOMNode
*
realOldChild
;
HRESULT
hr
;
TRACE
(
"%p->(%p,%p,%p)
\n
"
,
This
,
newChild
,
oldChild
,
outOldChild
);
...
...
@@ -624,7 +626,12 @@ static HRESULT WINAPI xmlnode_replaceChild(
if
(
outOldChild
)
*
outOldChild
=
NULL
;
old_child_ptr
=
impl_from_IXMLDOMNode
(
oldChild
)
->
node
;
hr
=
IXMLDOMNode_QueryInterface
(
oldChild
,
&
IID_IXMLDOMNode
,(
LPVOID
*
)
&
realOldChild
);
if
(
FAILED
(
hr
))
return
hr
;
old_child_ptr
=
impl_from_IXMLDOMNode
(
realOldChild
)
->
node
;
IXMLDOMNode_Release
(
realOldChild
);
if
(
old_child_ptr
->
parent
!=
This
->
node
)
{
WARN
(
"childNode %p is not a child of %p
\n
"
,
oldChild
,
iface
);
...
...
dlls/msxml3/tests/domdoc.c
View file @
27e9a983
...
...
@@ -1842,7 +1842,7 @@ static void test_replaceChild(void)
BSTR
str
;
VARIANT_BOOL
b
;
IXMLDOMDocument
*
doc
;
IXMLDOMElement
*
element
;
IXMLDOMElement
*
element
,
*
ba_element
;
IXMLDOMNode
*
fo_node
,
*
ba_node
,
*
lc_node
,
*
removed_node
,
*
temp_node
;
IXMLDOMNodeList
*
root_list
,
*
fo_list
;
IUnknown
*
unk1
,
*
unk2
;
...
...
@@ -1925,6 +1925,13 @@ static void test_replaceChild(void)
r
=
IXMLDOMNode_get_childNodes
(
fo_node
,
&
fo_list
);
ok
(
r
==
S_OK
,
"ret %08x
\n
"
,
r
);
/* MS quirk: replaceChild also accepts elements instead of nodes */
r
=
IXMLDOMNode_QueryInterface
(
ba_node
,
&
IID_IXMLDOMElement
,
(
void
**
)
&
ba_element
);
ok
(
r
==
S_OK
,
"ret %08x
\n
"
,
r
);
r
=
IXMLDOMElement_replaceChild
(
element
,
ba_node
,
(
IXMLDOMNode
*
)
ba_element
,
&
removed_node
);
ok
(
r
==
S_OK
,
"ret %08x
\n
"
,
r
);
r
=
IXMLDOMNodeList_get_length
(
fo_list
,
&
len
);
ok
(
r
==
S_OK
,
"ret %08x
\n
"
,
r
);
ok
(
len
==
0
,
"len %ld
\n
"
,
len
);
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment