Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
W
wine-winehq
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
wine
wine-winehq
Commits
2918a272
Commit
2918a272
authored
Aug 23, 2007
by
James Hawkins
Committed by
Alexandre Julliard
Aug 24, 2007
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
cabinet: Return the value of GetLastError if FDICopy fails.
parent
b1bd9208
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
5 additions
and
9 deletions
+5
-9
cabinet_main.c
dlls/cabinet/cabinet_main.c
+1
-1
fdi.c
dlls/cabinet/fdi.c
+0
-1
extract.c
dlls/cabinet/tests/extract.c
+4
-7
No files found.
dlls/cabinet/cabinet_main.c
View file @
2918a272
...
@@ -357,7 +357,7 @@ HRESULT WINAPI Extract(SESSION *dest, LPCSTR szCabName)
...
@@ -357,7 +357,7 @@ HRESULT WINAPI Extract(SESSION *dest, LPCSTR szCabName)
if
(
!
FDICopy
(
hfdi
,
name
,
path
,
0
,
if
(
!
FDICopy
(
hfdi
,
name
,
path
,
0
,
fdi_notify_extract
,
NULL
,
dest
))
fdi_notify_extract
,
NULL
,
dest
))
res
=
E_FAIL
;
res
=
HRESULT_FROM_WIN32
(
GetLastError
())
;
HeapFree
(
GetProcessHeap
(),
0
,
str
);
HeapFree
(
GetProcessHeap
(),
0
,
str
);
end:
end:
...
...
dlls/cabinet/fdi.c
View file @
2918a272
...
@@ -2495,7 +2495,6 @@ BOOL __cdecl FDICopy(
...
@@ -2495,7 +2495,6 @@ BOOL __cdecl FDICopy(
cabhf
=
PFDI_OPEN
(
hfdi
,
fullpath
,
_O_RDONLY
|
_O_BINARY
,
_S_IREAD
|
_S_IWRITE
);
cabhf
=
PFDI_OPEN
(
hfdi
,
fullpath
,
_O_RDONLY
|
_O_BINARY
,
_S_IREAD
|
_S_IWRITE
);
if
(
cabhf
==
-
1
)
{
if
(
cabhf
==
-
1
)
{
PFDI_INT
(
hfdi
)
->
perf
->
erfOper
=
FDIERROR_CABINET_NOT_FOUND
;
PFDI_INT
(
hfdi
)
->
perf
->
erfOper
=
FDIERROR_CABINET_NOT_FOUND
;
PFDI_INT
(
hfdi
)
->
perf
->
erfType
=
ERROR_FILE_NOT_FOUND
;
PFDI_INT
(
hfdi
)
->
perf
->
fError
=
TRUE
;
PFDI_INT
(
hfdi
)
->
perf
->
fError
=
TRUE
;
SetLastError
(
ERROR_FILE_NOT_FOUND
);
SetLastError
(
ERROR_FILE_NOT_FOUND
);
return
FALSE
;
return
FALSE
;
...
...
dlls/cabinet/tests/extract.c
View file @
2918a272
...
@@ -572,13 +572,10 @@ static void test_Extract(void)
...
@@ -572,13 +572,10 @@ static void test_Extract(void)
session
.
Operation
=
EXTRACT_FILLFILELIST
|
EXTRACT_EXTRACTFILES
;
session
.
Operation
=
EXTRACT_FILLFILELIST
|
EXTRACT_EXTRACTFILES
;
res
=
pExtract
(
&
session
,
"nonexistent.cab"
);
res
=
pExtract
(
&
session
,
"nonexistent.cab"
);
node
=
session
.
FileList
;
node
=
session
.
FileList
;
todo_wine
ok
(
res
==
HRESULT_FROM_WIN32
(
ERROR_FILE_NOT_FOUND
),
{
"Expected HRESULT_FROM_WIN32(ERROR_FILE_NOT_FOUND), got %08x
\n
"
,
res
);
ok
(
res
==
HRESULT_FROM_WIN32
(
ERROR_FILE_NOT_FOUND
),
ok
(
session
.
Error
.
erfOper
==
FDIERROR_CABINET_NOT_FOUND
,
"Expected HRESULT_FROM_WIN32(ERROR_FILE_NOT_FOUND), got %08x
\n
"
,
res
);
"Expected FDIERROR_CABINET_NOT_FOUND, got %d
\n
"
,
session
.
Error
.
erfOper
);
ok
(
session
.
Error
.
erfOper
==
FDIERROR_CABINET_NOT_FOUND
,
"Expected FDIERROR_CABINET_NOT_FOUND, got %d
\n
"
,
session
.
Error
.
erfOper
);
}
ok
(
session
.
FileSize
==
0
,
"Expected 0, got %d
\n
"
,
session
.
FileSize
);
ok
(
session
.
FileSize
==
0
,
"Expected 0, got %d
\n
"
,
session
.
FileSize
);
ok
(
session
.
Error
.
erfType
==
0
,
"Expected 0, got %d
\n
"
,
session
.
Error
.
erfType
);
ok
(
session
.
Error
.
erfType
==
0
,
"Expected 0, got %d
\n
"
,
session
.
Error
.
erfType
);
ok
(
session
.
Error
.
fError
==
TRUE
,
"Expected TRUE, got %d
\n
"
,
session
.
Error
.
fError
);
ok
(
session
.
Error
.
fError
==
TRUE
,
"Expected TRUE, got %d
\n
"
,
session
.
Error
.
fError
);
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment