comctl32: Unset active page while setting a new active page for a propsheet.

Before calling the PSN_SETACTIVE in PROPSHEET_SetCurSel set the active_page to -1. This prevents crashes and corruption of the property sheet if the application makes any modifications during the PSN_SETACTIVE.

comctl32: Unset active page while setting a new active page for a propsheet.
2a8463b5 · Aric Stewart · Alexandre Julliard · 06b41408 · 2a8463b5
Commit 2a8463b5 authored Mar 30, 2007 by Aric Stewart Committed by Alexandre Julliard Apr 02, 2007
Hide whitespace changes
Inline Side-by-side

Showing with 5 additions and 0 deletions

propsheet.c dlls/comctl32/propsheet.c +5 -0

No files found.
--- a/dlls/comctl32/propsheet.c
+++ b/dlls/comctl32/propsheet.c
@@ -2023,6 +2023,11 @@ static BOOL PROPSHEET_SetCurSel(HWND hwndDlg,
    return FALSE;
  }

+  /* unset active page while doing this transition. */
+  if (psInfo->active_page != -1)
+     ShowWindow(psInfo->proppage[psInfo->active_page].hwndPage, SW_HIDE);
+  psInfo->active_page = -1;
+
  while (1) {
    int result;
    PSHNOTIFY psn;