wininet: Stop leaking username and password.

2ac52b0e · Hans Leidekker · Alexandre Julliard · a57cc6dc · 2ac52b0e
Commit 2ac52b0e authored Dec 02, 2008 by Hans Leidekker Committed by Alexandre Julliard Dec 03, 2008
Show whitespace changes
Inline Side-by-side

Showing with 4 additions and 2 deletions

http.c dlls/wininet/http.c +4 -2

No files found.
--- a/dlls/wininet/http.c
+++ b/dlls/wininet/http.c
@@ -3518,12 +3518,14 @@ static DWORD HTTPSESSION_SetOption(WININETHANDLEHEADER *hdr, DWORD option, void 
    switch(option) {
    case INTERNET_OPTION_USERNAME:
    {
-        if (!(ses->lpszUserName = WININET_strdupW(buffer))) break;
+        HeapFree(GetProcessHeap(), 0, ses->lpszUserName);
+        if (!(ses->lpszUserName = WININET_strdupW(buffer))) return ERROR_OUTOFMEMORY;
        return ERROR_SUCCESS;
    }
    case INTERNET_OPTION_PASSWORD:
    {
-        if (!(ses->lpszPassword = WININET_strdupW(buffer))) break;
+        HeapFree(GetProcessHeap(), 0, ses->lpszPassword);
+        if (!(ses->lpszPassword = WININET_strdupW(buffer))) return ERROR_OUTOFMEMORY;
        return ERROR_SUCCESS;
    }
    default: break;