Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
W
wine-winehq
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
wine
wine-winehq
Commits
2ad3ff88
Commit
2ad3ff88
authored
Dec 27, 2004
by
Aric Stewart
Committed by
Alexandre Julliard
Dec 27, 2004
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Eliminate some fixed length buffers.
parent
816f8656
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
17 additions
and
8 deletions
+17
-8
action.c
dlls/msi/action.c
+17
-8
No files found.
dlls/msi/action.c
View file @
2ad3ff88
...
...
@@ -742,8 +742,8 @@ UINT ACTION_DoTopLevelINSTALL(MSIPACKAGE *package, LPCWSTR szPackagePath,
while
(
*
ptr
)
{
WCHAR
prop
[
0x100
]
;
WCHAR
val
[
0x100
]
;
WCHAR
*
prop
=
NULL
;
WCHAR
*
val
=
NULL
;
TRACE
(
"Looking at %s
\n
"
,
debugstr_w
(
ptr
));
...
...
@@ -754,10 +754,13 @@ UINT ACTION_DoTopLevelINSTALL(MSIPACKAGE *package, LPCWSTR szPackagePath,
DWORD
len
=
0
;
while
(
*
ptr
==
' '
)
ptr
++
;
strncpyW
(
prop
,
ptr
,
ptr2
-
ptr
);
prop
[
ptr2
-
ptr
]
=
0
;
len
=
ptr2
-
ptr
;
prop
=
HeapAlloc
(
GetProcessHeap
(),
0
,(
len
+
1
)
*
sizeof
(
WCHAR
));
strncpyW
(
prop
,
ptr
,
len
);
prop
[
len
]
=
0
;
ptr2
++
;
len
=
0
;
ptr
=
ptr2
;
while
(
*
ptr
&&
(
quote
||
(
!
quote
&&
*
ptr
!=
' '
)))
{
...
...
@@ -772,8 +775,9 @@ UINT ACTION_DoTopLevelINSTALL(MSIPACKAGE *package, LPCWSTR szPackagePath,
ptr2
++
;
len
-=
2
;
}
val
=
HeapAlloc
(
GetProcessHeap
(),
0
,(
len
+
1
)
*
sizeof
(
WCHAR
));
strncpyW
(
val
,
ptr2
,
len
);
val
[
len
]
=
0
;
val
[
len
]
=
0
;
if
(
strlenW
(
prop
)
>
0
)
{
...
...
@@ -781,6 +785,8 @@ UINT ACTION_DoTopLevelINSTALL(MSIPACKAGE *package, LPCWSTR szPackagePath,
debugstr_w
(
prop
),
debugstr_w
(
val
));
MSI_SetPropertyW
(
package
,
prop
,
val
);
}
HeapFree
(
GetProcessHeap
(),
0
,
val
);
HeapFree
(
GetProcessHeap
(),
0
,
prop
);
}
ptr
++
;
}
...
...
@@ -2361,7 +2367,7 @@ static UINT ACTION_CostFinalize(MSIPACKAGE *package)
}
else
{
if
(
file
->
Version
[
0
]
)
if
(
file
->
Version
)
{
DWORD
handle
;
DWORD
versize
;
...
...
@@ -2872,7 +2878,10 @@ static UINT ACTION_InstallFiles(MSIPACKAGE *package)
rc
=
0
;
}
else
break
;
{
ERR
(
"Ignoring Error and continuing...
\n
"
);
rc
=
0
;
}
}
else
file
->
State
=
4
;
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment