msi: Avoid using dialog record after free.

2ad9312f · Dmitry Timoshkov · Alexandre Julliard · e67a00b4 · 2ad9312f
Commit 2ad9312f authored Aug 18, 2015 by Dmitry Timoshkov Committed by Alexandre Julliard Aug 18, 2015
Hide whitespace changes
Inline Side-by-side

Showing with 5 additions and 2 deletions

dialog.c dlls/msi/dialog.c +5 -2

No files found.
--- a/dlls/msi/dialog.c
+++ b/dlls/msi/dialog.c
@@ -3664,8 +3664,11 @@ static LRESULT msi_dialog_oncreate( HWND hwnd, LPCREATESTRUCTW cs )
    if (!dialog->default_font)
    {
        dialog->default_font = strdupW(dfv);
-        msiobj_release( &rec->hdr );
-        if (!dialog->default_font) return -1;
+        if (!dialog->default_font)
+        {
+            msiobj_release( &rec->hdr );
+            return -1;
+        }
    }

    title = msi_get_deformatted_field( dialog->package, rec, 7 );