Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
W
wine-winehq
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
wine
wine-winehq
Commits
2d5c9f4f
Commit
2d5c9f4f
authored
Mar 03, 2013
by
Nikolay Sivov
Committed by
Alexandre Julliard
Mar 04, 2013
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
msxml3: Filter unsupported child nodes in insertBefore() for elements.
parent
ce4291c5
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
26 additions
and
4 deletions
+26
-4
element.c
dlls/msxml3/element.c
+19
-3
domdoc.c
dlls/msxml3/tests/domdoc.c
+7
-1
No files found.
dlls/msxml3/element.c
View file @
2d5c9f4f
...
...
@@ -301,13 +301,29 @@ static HRESULT WINAPI domelem_get_attributes(
static
HRESULT
WINAPI
domelem_insertBefore
(
IXMLDOMElement
*
iface
,
IXMLDOMNode
*
newNode
,
VARIANT
refChild
,
IXMLDOMNode
**
o
utOldN
ode
)
IXMLDOMNode
**
o
ld_n
ode
)
{
domelem
*
This
=
impl_from_IXMLDOMElement
(
iface
);
DOMNodeType
type
;
HRESULT
hr
;
TRACE
(
"(%p)->(%p %s %p)
\n
"
,
This
,
newNode
,
debugstr_variant
(
&
refChild
),
outOldNode
);
TRACE
(
"(%p)->(%p %s %p)
\n
"
,
This
,
newNode
,
debugstr_variant
(
&
refChild
),
old_node
);
hr
=
IXMLDOMNode_get_nodeType
(
newNode
,
&
type
);
if
(
hr
!=
S_OK
)
return
hr
;
return
node_insert_before
(
&
This
->
node
,
newNode
,
&
refChild
,
outOldNode
);
TRACE
(
"new node type %d
\n
"
,
type
);
switch
(
type
)
{
case
NODE_DOCUMENT
:
case
NODE_DOCUMENT_TYPE
:
case
NODE_ENTITY
:
case
NODE_NOTATION
:
if
(
old_node
)
*
old_node
=
NULL
;
return
E_FAIL
;
default:
return
node_insert_before
(
&
This
->
node
,
newNode
,
&
refChild
,
old_node
);
}
}
static
HRESULT
WINAPI
domelem_replaceChild
(
...
...
dlls/msxml3/tests/domdoc.c
View file @
2d5c9f4f
...
...
@@ -4,7 +4,7 @@
* Copyright 2005 Mike McCormack for CodeWeavers
* Copyright 2007-2008 Alistair Leslie-Hughes
* Copyright 2010-2011 Adam Martinson for CodeWeavers
* Copyright 2010-201
2
Nikolay Sivov for CodeWeavers
* Copyright 2010-201
3
Nikolay Sivov for CodeWeavers
*
* This library is free software; you can redistribute it and/or
* modify it under the terms of the GNU Lesser General Public
...
...
@@ -8484,6 +8484,12 @@ static void test_insertBefore(void)
todo_wine
EXPECT_REF
(
elem2
,
2
);
/* document to element */
V_VT
(
&
v
)
=
VT_DISPATCH
;
V_DISPATCH
(
&
v
)
=
NULL
;
hr
=
IXMLDOMElement_insertBefore
(
elem1
,
(
IXMLDOMNode
*
)
doc
,
v
,
NULL
);
ok
(
hr
==
E_FAIL
,
"got 0x%08x
\n
"
,
hr
);
V_VT
(
&
v
)
=
VT_DISPATCH
;
V_DISPATCH
(
&
v
)
=
NULL
;
node
=
NULL
;
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment