quartz/dsoundrender: Don't drop stream_cs in DSoundRender_HandleEndOfStream().

We don't grab stream_cs to change any variables checked here, except to reset flush_event, and that cannot result in a deadlock. The only possible deadlocks here are: (1) between this function and Receive(), which is correct, as the two should presumably be serialized; (2) between this function and EndFlush(); however, in that case we expect BeginFlush() first, which will unblock the streaming thread. Signed-off-by: Zebediah Figura <z.figura12@gmail.com> Signed-off-by: Alexandre Julliard <julliard@winehq.org>

quartz/dsoundrender: Don't drop stream_cs in DSoundRender_HandleEndOfStream().
2d6043eb · Zebediah Figura · Alexandre Julliard · 3933ceca · 2d6043eb
Commit 2d6043eb authored Nov 30, 2020 by Zebediah Figura Committed by Alexandre Julliard Dec 01, 2020
Hide whitespace changes
Inline Side-by-side

Showing with 0 additions and 2 deletions

dsoundrender.c dlls/quartz/dsoundrender.c +0 -2

No files found.
--- a/dlls/quartz/dsoundrender.c
+++ b/dlls/quartz/dsoundrender.c
@@ -236,9 +236,7 @@ static HRESULT DSoundRender_HandleEndOfStream(struct dsound_render *This)
        if (pos1 == pos2)
            break;

-        LeaveCriticalSection(&This->stream_cs);
        WaitForSingleObject(This->flush_event, 10);
-        EnterCriticalSection(&This->stream_cs);
    }

    return S_OK;