Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
W
wine-winehq
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
wine
wine-winehq
Commits
2d8ae2cf
Commit
2d8ae2cf
authored
Apr 05, 2007
by
Rob Shearman
Committed by
Alexandre Julliard
Apr 05, 2007
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
ole32: Check for COM not being initialised and an invalid window handle being…
ole32: Check for COM not being initialised and an invalid window handle being input to RegisterDragDrop.
parent
db4972f1
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
9 additions
and
7 deletions
+9
-7
ole2.c
dlls/ole32/ole2.c
+9
-0
dragdrop.c
dlls/ole32/tests/dragdrop.c
+0
-7
No files found.
dlls/ole32/ole2.c
View file @
2d8ae2cf
...
...
@@ -289,9 +289,18 @@ HRESULT WINAPI RegisterDragDrop(
TRACE
(
"(%p,%p)
\n
"
,
hwnd
,
pDropTarget
);
if
(
!
COM_CurrentApt
())
{
ERR
(
"COM not initialized
\n
"
);
return
CO_E_NOTINITIALIZED
;
}
if
(
!
pDropTarget
)
return
E_INVALIDARG
;
if
(
!
IsWindow
(
hwnd
))
return
DRAGDROP_E_INVALIDHWND
;
/*
* First, check if the window is already registered.
*/
...
...
dlls/ole32/tests/dragdrop.c
View file @
2d8ae2cf
...
...
@@ -113,7 +113,6 @@ START_TEST(dragdrop)
HRESULT
hr
;
hr
=
RegisterDragDrop
(
GetDesktopWindow
(),
&
DropTarget
);
todo_wine
ok
(
hr
==
CO_E_NOTINITIALIZED
,
"RegisterDragDrop without OLE initialized should have returned CO_E_NOTINITIALIZED instead of 0x%08x
\n
"
,
hr
);
OleInitialize
(
NULL
);
...
...
@@ -122,19 +121,14 @@ START_TEST(dragdrop)
ok
(
hr
==
E_INVALIDARG
,
"RegisterDragDrop with NULL IDropTarget * should return E_INVALIDARG instead of 0x%08x
\n
"
,
hr
);
hr
=
RegisterDragDrop
(
NULL
,
&
DropTarget
);
todo_wine
ok
(
hr
==
DRAGDROP_E_INVALIDHWND
,
"RegisterDragDrop with NULL hwnd should return DRAGDROP_E_INVALIDHWND instead of 0x%08x
\n
"
,
hr
);
hr
=
RegisterDragDrop
((
HWND
)
0xdeadbeef
,
&
DropTarget
);
todo_wine
ok
(
hr
==
DRAGDROP_E_INVALIDHWND
,
"RegisterDragDrop with garbage hwnd should return DRAGDROP_E_INVALIDHWND instead of 0x%08x
\n
"
,
hr
);
todo_wine
ok
(
droptarget_addref_called
==
0
,
"DropTarget_AddRef shouldn't have been called
\n
"
);
hr
=
RegisterDragDrop
(
GetDesktopWindow
(),
&
DropTarget
);
todo_wine
ok_ole_success
(
hr
,
"RegisterDragDrop"
);
todo_wine
ok
(
droptarget_addref_called
==
1
,
"DropTarget_AddRef should have been called once, not %d times
\n
"
,
droptarget_addref_called
);
hr
=
RegisterDragDrop
(
GetDesktopWindow
(),
&
DropTarget
);
...
...
@@ -148,7 +142,6 @@ START_TEST(dragdrop)
hr
=
RevokeDragDrop
(
GetDesktopWindow
());
todo_wine
ok_ole_success
(
hr
,
"RevokeDragDrop"
);
todo_wine
ok
(
droptarget_release_called
==
1
,
"DropTarget_Release should have been called once, not %d times
\n
"
,
droptarget_release_called
);
hr
=
RevokeDragDrop
(
NULL
);
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment