msi: Fix potential NULL pointer dereference in ILockBytes_Release (Coverity).

2fbe8d23 · Nikolay Sivov · Alexandre Julliard · 9598a509 · 2fbe8d23
Commit 2fbe8d23 authored Jan 24, 2009 by Nikolay Sivov Committed by Alexandre Julliard Jan 26, 2009
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 2 deletions

storages.c dlls/msi/storages.c +2 -2

No files found.
--- a/dlls/msi/storages.c
+++ b/dlls/msi/storages.c
@@ -134,7 +134,7 @@ static UINT STORAGES_get_row( struct tagMSIVIEW *view, UINT row, MSIRECORD **rec

 static HRESULT stream_to_storage(IStream *stm, IStorage **stg)
 {
-    ILockBytes *lockbytes;
+    ILockBytes *lockbytes = NULL;
    STATSTG stat;
    LPVOID data;
    HRESULT hr;
@@ -177,7 +177,7 @@ static HRESULT stream_to_storage(IStream *stm, IStorage **stg)

 done:
    msi_free(data);
-    ILockBytes_Release(lockbytes);
+    if (lockbytes) ILockBytes_Release(lockbytes);
    return hr;
 }