Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
W
wine-winehq
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
wine
wine-winehq
Commits
30e5892c
Commit
30e5892c
authored
Aug 22, 2023
by
Rémi Bernon
Committed by
Alexandre Julliard
Sep 14, 2023
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
dmloader: Always return S_FALSE from DllCanUnloadNow.
parent
6798b734
Show whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
0 additions
and
32 deletions
+0
-32
container.c
dlls/dmloader/container.c
+0
-3
dmloader_main.c
dlls/dmloader/dmloader_main.c
+0
-21
dmloader_private.h
dlls/dmloader/dmloader_private.h
+0
-5
loader.c
dlls/dmloader/loader.c
+0
-3
No files found.
dlls/dmloader/container.c
View file @
30e5892c
...
@@ -137,7 +137,6 @@ static ULONG WINAPI IDirectMusicContainerImpl_Release(IDirectMusicContainer *ifa
...
@@ -137,7 +137,6 @@ static ULONG WINAPI IDirectMusicContainerImpl_Release(IDirectMusicContainer *ifa
if
(
This
->
pStream
)
if
(
This
->
pStream
)
destroy_dmcontainer
(
This
);
destroy_dmcontainer
(
This
);
HeapFree
(
GetProcessHeap
(),
0
,
This
);
HeapFree
(
GetProcessHeap
(),
0
,
This
);
unlock_module
();
}
}
return
ref
;
return
ref
;
...
@@ -666,8 +665,6 @@ HRESULT create_dmcontainer(REFIID lpcGUID, void **ppobj)
...
@@ -666,8 +665,6 @@ HRESULT create_dmcontainer(REFIID lpcGUID, void **ppobj)
obj
->
pContainedObjects
=
HeapAlloc
(
GetProcessHeap
(),
HEAP_ZERO_MEMORY
,
sizeof
(
struct
list
));
obj
->
pContainedObjects
=
HeapAlloc
(
GetProcessHeap
(),
HEAP_ZERO_MEMORY
,
sizeof
(
struct
list
));
list_init
(
obj
->
pContainedObjects
);
list_init
(
obj
->
pContainedObjects
);
lock_module
();
hr
=
IDirectMusicContainer_QueryInterface
(
&
obj
->
IDirectMusicContainer_iface
,
lpcGUID
,
ppobj
);
hr
=
IDirectMusicContainer_QueryInterface
(
&
obj
->
IDirectMusicContainer_iface
,
lpcGUID
,
ppobj
);
IDirectMusicContainer_Release
(
&
obj
->
IDirectMusicContainer_iface
);
IDirectMusicContainer_Release
(
&
obj
->
IDirectMusicContainer_iface
);
...
...
dlls/dmloader/dmloader_main.c
View file @
30e5892c
...
@@ -36,8 +36,6 @@
...
@@ -36,8 +36,6 @@
WINE_DEFAULT_DEBUG_CHANNEL
(
dmloader
);
WINE_DEFAULT_DEBUG_CHANNEL
(
dmloader
);
LONG
module_ref
=
0
;
typedef
struct
{
typedef
struct
{
IClassFactory
IClassFactory_iface
;
IClassFactory
IClassFactory_iface
;
HRESULT
(
*
fnCreateInstance
)(
REFIID
riid
,
void
**
ppv
);
HRESULT
(
*
fnCreateInstance
)(
REFIID
riid
,
void
**
ppv
);
...
@@ -73,15 +71,11 @@ static HRESULT WINAPI ClassFactory_QueryInterface(IClassFactory *iface, REFIID r
...
@@ -73,15 +71,11 @@ static HRESULT WINAPI ClassFactory_QueryInterface(IClassFactory *iface, REFIID r
static
ULONG
WINAPI
ClassFactory_AddRef
(
IClassFactory
*
iface
)
static
ULONG
WINAPI
ClassFactory_AddRef
(
IClassFactory
*
iface
)
{
{
lock_module
();
return
2
;
/* non-heap based object */
return
2
;
/* non-heap based object */
}
}
static
ULONG
WINAPI
ClassFactory_Release
(
IClassFactory
*
iface
)
static
ULONG
WINAPI
ClassFactory_Release
(
IClassFactory
*
iface
)
{
{
unlock_module
();
return
1
;
/* non-heap based object */
return
1
;
/* non-heap based object */
}
}
...
@@ -103,12 +97,6 @@ static HRESULT WINAPI ClassFactory_CreateInstance(IClassFactory *iface, IUnknown
...
@@ -103,12 +97,6 @@ static HRESULT WINAPI ClassFactory_CreateInstance(IClassFactory *iface, IUnknown
static
HRESULT
WINAPI
ClassFactory_LockServer
(
IClassFactory
*
iface
,
BOOL
dolock
)
static
HRESULT
WINAPI
ClassFactory_LockServer
(
IClassFactory
*
iface
,
BOOL
dolock
)
{
{
TRACE
(
"(%d)
\n
"
,
dolock
);
TRACE
(
"(%d)
\n
"
,
dolock
);
if
(
dolock
)
lock_module
();
else
unlock_module
();
return
S_OK
;
return
S_OK
;
}
}
...
@@ -123,15 +111,6 @@ static const IClassFactoryVtbl classfactory_vtbl = {
...
@@ -123,15 +111,6 @@ static const IClassFactoryVtbl classfactory_vtbl = {
static
IClassFactoryImpl
dm_loader_CF
=
{{
&
classfactory_vtbl
},
create_dmloader
};
static
IClassFactoryImpl
dm_loader_CF
=
{{
&
classfactory_vtbl
},
create_dmloader
};
static
IClassFactoryImpl
dm_container_CF
=
{{
&
classfactory_vtbl
},
create_dmcontainer
};
static
IClassFactoryImpl
dm_container_CF
=
{{
&
classfactory_vtbl
},
create_dmcontainer
};
/******************************************************************
* DllCanUnloadNow (DMLOADER.@)
*/
HRESULT
WINAPI
DllCanUnloadNow
(
void
)
{
TRACE
(
"() ref=%ld
\n
"
,
module_ref
);
return
module_ref
?
S_FALSE
:
S_OK
;
}
/******************************************************************
/******************************************************************
* DllGetClassObject (DMLOADER.@)
* DllGetClassObject (DMLOADER.@)
...
...
dlls/dmloader/dmloader_private.h
View file @
30e5892c
...
@@ -44,11 +44,6 @@
...
@@ -44,11 +44,6 @@
#define ICOM_THIS_MULTI(impl,field,iface) impl* const This=(impl*)((char*)(iface) - offsetof(impl,field))
#define ICOM_THIS_MULTI(impl,field,iface) impl* const This=(impl*)((char*)(iface) - offsetof(impl,field))
/* dmloader.dll global (for DllCanUnloadNow) */
extern
LONG
module_ref
;
static
inline
void
lock_module
(
void
)
{
InterlockedIncrement
(
&
module_ref
);
}
static
inline
void
unlock_module
(
void
)
{
InterlockedDecrement
(
&
module_ref
);
}
/*****************************************************************************
/*****************************************************************************
* Interfaces
* Interfaces
*/
*/
...
...
dlls/dmloader/loader.c
View file @
30e5892c
...
@@ -157,7 +157,6 @@ static ULONG WINAPI IDirectMusicLoaderImpl_Release(IDirectMusicLoader8 *iface)
...
@@ -157,7 +157,6 @@ static ULONG WINAPI IDirectMusicLoaderImpl_Release(IDirectMusicLoader8 *iface)
for
(
i
=
0
;
i
<
ARRAY_SIZE
(
classes
);
i
++
)
for
(
i
=
0
;
i
<
ARRAY_SIZE
(
classes
);
i
++
)
HeapFree
(
GetProcessHeap
(),
0
,
This
->
search_paths
[
i
]);
HeapFree
(
GetProcessHeap
(),
0
,
This
->
search_paths
[
i
]);
HeapFree
(
GetProcessHeap
(),
0
,
This
);
HeapFree
(
GetProcessHeap
(),
0
,
This
);
unlock_module
();
}
}
return
ref
;
return
ref
;
...
@@ -940,7 +939,5 @@ HRESULT create_dmloader(REFIID lpcGUID, void **ppobj)
...
@@ -940,7 +939,5 @@ HRESULT create_dmloader(REFIID lpcGUID, void **ppobj)
dls
->
bInvalidDefaultDLS
=
TRUE
;
dls
->
bInvalidDefaultDLS
=
TRUE
;
}
}
lock_module
();
return
IDirectMusicLoader_QueryInterface
(
&
obj
->
IDirectMusicLoader8_iface
,
lpcGUID
,
ppobj
);
return
IDirectMusicLoader_QueryInterface
(
&
obj
->
IDirectMusicLoader8_iface
,
lpcGUID
,
ppobj
);
}
}
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment