Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
W
wine-winehq
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
wine
wine-winehq
Commits
33598db7
Commit
33598db7
authored
Apr 24, 2023
by
Mohamad Al-Jaf
Committed by
Alexandre Julliard
Apr 26, 2023
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
shell32: Fix last parameter behavior in SHBindToFolderIDListParent().
parent
27434f36
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
6 additions
and
5 deletions
+6
-5
pidl.c
dlls/shell32/pidl.c
+4
-3
shlfolder.c
dlls/shell32/tests/shlfolder.c
+2
-2
No files found.
dlls/shell32/pidl.c
View file @
33598db7
...
...
@@ -1304,12 +1304,13 @@ HRESULT WINAPI SHBindToFolderIDListParent(IShellFolder *psf, LPCITEMIDLIST pidl,
TRACE_
(
shell
)(
"%p,%p,%s
\n
"
,
psf
,
pidl
,
debugstr_guid
(
riid
));
pdump
(
pidl
);
if
(
ppidlLast
)
*
ppidlLast
=
NULL
;
if
(
!
pidl
||
!
ppv
)
return
E_INVALIDARG
;
*
ppv
=
NULL
;
if
(
ppidlLast
)
*
ppidlLast
=
NULL
;
if
(
!
psf
)
{
...
...
dlls/shell32/tests/shlfolder.c
View file @
33598db7
...
...
@@ -779,7 +779,7 @@ static void test_GetDisplayName(void)
hr
=
SHBindToParent
(
NULL
,
&
IID_IShellFolder
,
(
void
**
)
&
psfPersonal
,
&
pidlLast
);
ok
(
hr
==
E_INVALIDARG
||
broken
(
hr
==
E_OUTOFMEMORY
)
/* XP */
,
"SHBindToParent(NULL) should fail! hr = %08lx
\n
"
,
hr
);
todo_wine
ok
(
pidlLast
==
NULL
,
"got %p
\n
"
,
pidlLast
);
ok
(
pidlLast
==
NULL
,
"got %p
\n
"
,
pidlLast
);
/* But it succeeds with an empty PIDL. */
hr
=
SHBindToParent
(
pidlEmpty
,
&
IID_IShellFolder
,
(
void
**
)
&
psfPersonal
,
&
pidlLast
);
...
...
@@ -5601,7 +5601,7 @@ static void test_SHBindToFolderIDListParent(void)
pidl_last
=
(
LPITEMIDLIST
)
0xdeadbeef
;
hr
=
pSHBindToFolderIDListParent
(
NULL
,
NULL
,
&
IID_IShellFolder
,
(
void
**
)
&
psf
,
&
pidl_last
);
ok
(
hr
==
E_INVALIDARG
,
"got %#lx
\n
"
,
hr
);
todo_wine
ok
(
pidl_last
==
NULL
,
"got %p
\n
"
,
pidl_last
);
ok
(
pidl_last
==
NULL
,
"got %p
\n
"
,
pidl_last
);
}
START_TEST
(
shlfolder
)
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment