Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
W
wine-winehq
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
wine
wine-winehq
Commits
345ab7d5
Commit
345ab7d5
authored
Mar 11, 2010
by
Nikolay Sivov
Committed by
Alexandre Julliard
Mar 15, 2010
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
shell32/shellview: Don't crash on ::DragLeave called without droptraget.
parent
78c909fb
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
23 additions
and
7 deletions
+23
-7
shlview.c
dlls/shell32/shlview.c
+15
-7
shlview.c
dlls/shell32/tests/shlview.c
+8
-0
No files found.
dlls/shell32/shlview.c
View file @
345ab7d5
...
...
@@ -2407,17 +2407,25 @@ static HRESULT WINAPI ISVDropTarget_DragOver(IDropTarget *iface, DWORD grfKeySta
return
drag_notify_subitem
(
This
,
grfKeyState
,
pt
,
pdwEffect
);
}
static
HRESULT
WINAPI
ISVDropTarget_DragLeave
(
IDropTarget
*
iface
)
{
static
HRESULT
WINAPI
ISVDropTarget_DragLeave
(
IDropTarget
*
iface
)
{
IShellViewImpl
*
This
=
impl_from_IDropTarget
(
iface
);
IDropTarget_DragLeave
(
This
->
pCurDropTarget
);
if
(
This
->
pCurDropTarget
)
{
IDropTarget_DragLeave
(
This
->
pCurDropTarget
);
IDropTarget_Release
(
This
->
pCurDropTarget
);
This
->
pCurDropTarget
=
NULL
;
}
if
(
This
->
pCurDataObject
)
{
IDataObject_Release
(
This
->
pCurDataObject
);
This
->
pCurDataObject
=
NULL
;
}
IDropTarget_Release
(
This
->
pCurDropTarget
);
IDataObject_Release
(
This
->
pCurDataObject
);
This
->
pCurDataObject
=
NULL
;
This
->
pCurDropTarget
=
NULL
;
This
->
iDragOverItem
=
0
;
return
S_OK
;
}
...
...
dlls/shell32/tests/shlview.c
View file @
345ab7d5
...
...
@@ -318,6 +318,7 @@ static void test_IShellView_CreateViewWindow(void)
IShellFolder
*
desktop
;
FOLDERSETTINGS
settings
;
IShellView
*
view
;
IDropTarget
*
dt
;
HWND
hwnd_view
;
HRESULT
hr
;
RECT
r
=
{
0
};
...
...
@@ -346,6 +347,13 @@ if (0)
ok
(
hr
==
E_UNEXPECTED
,
"got (0x%08x)
\n
"
,
hr
);
ok
(
hwnd_view
==
0
,
"got %p
\n
"
,
hwnd_view
);
/* ::DragLeave without drag operation */
hr
=
IShellView_QueryInterface
(
view
,
&
IID_IDropTarget
,
(
void
**
)
&
dt
);
ok
(
hr
==
S_OK
,
"got (0x%08x)
\n
"
,
hr
);
hr
=
IDropTarget_DragLeave
(
dt
);
ok
(
hr
==
S_OK
,
"got (0x%08x)
\n
"
,
hr
);
IDropTarget_Release
(
dt
);
IShellView_Release
(
view
);
IShellFolder_Release
(
desktop
);
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment