msxml3: Handle NULL XML declaration.

Signed-off-by: Daniel Lehman <dlehman25@gmail.com> Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com> Signed-off-by: Alexandre Julliard <julliard@winehq.org>

msxml3: Handle NULL XML declaration.
35ae0102 · Daniel Lehman · Alexandre Julliard · fd3cf6f2 · 35ae0102 · 35ae0102
Commit 35ae0102 authored Oct 22, 2021 by Daniel Lehman Committed by Alexandre Julliard Oct 22, 2021
Hide whitespace changes
Inline Side-by-side

Showing with 3 additions and 1 deletion

pi.c dlls/msxml3/pi.c +3 -0

domdoc.c dlls/msxml3/tests/domdoc.c +0 -1

No files found.
--- a/dlls/msxml3/pi.c
+++ b/dlls/msxml3/pi.c
@@ -754,6 +754,9 @@ HRESULT dom_pi_put_xml_decl(IXMLDOMNode *node, BSTR data)
    HRESULT hr;
    BSTR name;

+    if (!data)
+        return XML_E_XMLDECLSYNTAX;
+
    node_obj = get_node_obj(node);
    hr = node_set_content(node_obj, data);
    if (FAILED(hr))

--- a/dlls/msxml3/tests/domdoc.c
+++ b/dlls/msxml3/tests/domdoc.c
@@ -8596,7 +8596,6 @@ static void test_createProcessingInstruction(void)
    hr = IXMLDOMDocument_createProcessingInstruction(doc, NULL, _bstr_("version=\"1.0\" encoding=\"UTF-8\""), &pi);
    ok(hr == E_FAIL, "got 0x%08x\n", hr);
    hr = IXMLDOMDocument_createProcessingInstruction(doc, _bstr_("xml"), NULL, &pi);
-todo_wine
    ok(hr == XML_E_XMLDECLSYNTAX, "got 0x%08x\n", hr);
    hr = IXMLDOMDocument_createProcessingInstruction(doc, _bstr_("xml"), _bstr_("version=\"1.0\" encoding=UTF-8"), &pi);
    ok(hr == XML_E_MISSINGQUOTE, "got 0x%08x\n", hr);